-
-
Notifications
You must be signed in to change notification settings - Fork 44
chore(release): bump version to 1.3.14 #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Replace references to ctx.chatluna.config.isLog with ctx.chatluna.currentConfig.isLog to use the active configuration instead of the static config object. Also simplify type filters in image content filtering by removing unnecessary type guards that were redundant after null filtering.
Bump all package versions: - Core: 1.3.13 -> 1.3.14 - Shared adapter: 1.0.21 -> 1.0.22 - All adapters: bump patch version - Update peerDependencies to use new core/shared-adapter versions This release includes image fetch error handling improvements and non-blocking log file operations.
Walkthrough在多个包中统一将配置访问点从 Changes
Sequence Diagram(s)(此变更为配置属性替换与类型过滤简化,未引入新的跨组件控制流或新功能,故省略序列图) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @dingyi222666, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is a routine maintenance release that bumps the versions of all Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request primarily focuses on bumping package versions for a new release, 1.3.14. It includes updates to the core package, shared adapter, and all other adapter packages. The changes also incorporate a few bug fixes, such as using currentConfig instead of config for logging, which ensures runtime configuration changes are respected. Additionally, there are some code simplifications. My review focuses on a recurring simplification pattern that might reduce type safety.
Rename the ChatLunaService.config property to currentConfig for better clarity about its role as the active configuration instance. Update all references throughout the codebase: - ChatInterface class: infiniteContext, rawOnCensor, infiniteContextThreshold - ChatLunaService: all internal service instantiations - ChatInterfaceWrapper: reasoning content and config initialization This aligns with the naming convention established in adapters for distinguishing between static and active configuration instances.
Summary
This PR bumps all package versions to 1.3.14, including core version updates and adapter dependency updates to reflect recent fixes and improvements.
Bug fixes
Other Changes