feat(ai-service): Replace task_results global dict with Redis-backed task store#363
Open
ugoocreates-pixel wants to merge 2 commits into
Open
feat(ai-service): Replace task_results global dict with Redis-backed task store#363ugoocreates-pixel wants to merge 2 commits into
feat(ai-service): Replace task_results global dict with Redis-backed task store#363ugoocreates-pixel wants to merge 2 commits into
Conversation
Contributor
|
Hi 👋 Appreciate this PR! The CI is flagging a failing check — could you take a peek at the failed job and push a fix? Happy to help if you need a hand 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #271
This PR replaces the module-level in-memory dictionary
task_resultsin the AI Service (app/ai-service/tasks.py) with a persistent, Redis-backed task store.Why this is necessary:
Changes Made
task_results: Deleted thetask_resultsglobal dictionary.get_redis_client) targeting the configuredREDIS_URL.tasks.set_statusto write task payload states directly to Redis with a TTL of 24 hours (86400seconds) matching Celery'sresult_expires.tasks.get_task_statusto check Celery'sAsyncResultstatus first, and fallback to the Redis-backed store on failure or missing keys.app/ai-service/tests/test_tasks_redis.pycovering: