feat: enforce maximum Merkle proof length in claim_with_proof to prev…#348
Merged
kilodesodiq-arch merged 4 commits intoJul 19, 2026
Merged
Conversation
Justprotocol
force-pushed
the
feature/claim-proof-cap
branch
from
July 16, 2026 08:50
b88dd7f to
587c210
Compare
Contributor
|
Awesome work on this! Thanks for the contribution 🚀 Merging now. |
Contributor
|
Hi 👋 Thanks for this PR! There are some merge conflicts with the current main. Could you rebase onto main and push when you have a moment? Once it's clean we'll get it merged 🚀 |
Contributor
Author
on it.. thanks for the feedback |
Justprotocol
force-pushed
the
feature/claim-proof-cap
branch
from
July 17, 2026 17:40
94dcee3 to
f4d8dd2
Compare
Contributor
Author
|
hi @kilodesodiq-arch please check now , i fixed the conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enforces a maximum Merkle proof length of 32 in
claim_with_proofto protect against CPU-exhaustion/DoS attacks from overly large proof vectors.Changes
lib.rs: AddedProofTooLarge = 19error code and validatedproof.len() <= 32at the start ofclaim_with_proof.aid_escrow_tests.rs: Added unit tests verifying the contract safely rejects oversized proofs and throwsProofTooLarge.Closes #227