Skip to content

Feature/pre allocate memory#239

Merged
dwr-zroy merged 1 commit into
Feature/wrims-devopsfrom
Feature/PreAllocateMemory
Oct 2, 2025
Merged

Feature/pre allocate memory#239
dwr-zroy merged 1 commit into
Feature/wrims-devopsfrom
Feature/PreAllocateMemory

Conversation

@hxiedwr

@hxiedwr hxiedwr commented Sep 15, 2025

Copy link
Copy Markdown
Contributor

Set max limit for memory allocation when new package/patch is release but not re-open the GUI package.

@hxiedwr hxiedwr requested a review from dwr-zroy September 15, 2025 22:52
@dwr-zroy

Copy link
Copy Markdown

Code change looks good, but those commit messages are pretty cryptic. If you know how to clean those up, that would be good for future documentation of the change.

@hxiedwr

hxiedwr commented Sep 16, 2025 via email

Copy link
Copy Markdown
Contributor Author

@dwr-zroy

dwr-zroy commented Sep 16, 2025

Copy link
Copy Markdown

I use Git GUI. It is difficult to modify the log of commit for me. I am wondering if you could help me from your side. Also, it seems I can only debug the code after I commit the code. It seems an issue as many times, my code modifications won’t work but still are committed.

I would recommend using git from the command line if you are having issues with the GUI client. The CLI is very well documented and most GUI clients that I have used have weird behavior. The CLI documentation is pretty well organized on git-scm.com

I can help with the commit re-naming. Can you provide me with commit messages that I can use. Feel free to just provide them via this GitHub chat.

@hxiedwr

hxiedwr commented Sep 17, 2025 via email

Copy link
Copy Markdown
Contributor Author

Set the limit for memory allocation when a new package/patch is
released, but not when re-opening the GUI package.
@dwr-zroy dwr-zroy force-pushed the Feature/PreAllocateMemory branch from be3209d to b3f693a Compare September 17, 2025 16:40

@dwr-zroy dwr-zroy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dwr-zroy dwr-zroy merged commit fa5f74c into Feature/wrims-devops Oct 2, 2025
1 check passed
@dwr-zroy dwr-zroy deleted the Feature/PreAllocateMemory branch October 2, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants