Feature/pre allocate memory#239
Conversation
|
Code change looks good, but those commit messages are pretty cryptic. If you know how to clean those up, that would be good for future documentation of the change. |
|
I use Git GUI. It is difficult to modify the log of commit for me. I am wondering if you could help me from your side.
Also, it seems I can only debug the code after I commit the code. It seems an issue as many times, my code modifications won’t work but still are committed.
From: Zachary Roy ***@***.***>
Sent: Monday, September 15, 2025 4:05 PM
To: CentralValleyModeling/wrims ***@***.***>
Cc: Xie, ***@***.*** ***@***.***>; Author ***@***.***>
Subject: Re: [CentralValleyModeling/wrims] Feature/pre allocate memory (PR #239)
[https://avatars.githubusercontent.com/u/134561183?s=20&v=4]dwr-zroy left a comment (CentralValleyModeling/wrims#239)<#239 (comment)>
Code change looks good, but those commit messages are pretty cryptic. If you know how to clean those up, that would be good for future documentation of the change.
—
Reply to this email directly, view it on GitHub<#239 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AC7C7KS5XQ7TZNED7VT5YQD3S5AYNAVCNFSM6AAAAACGS4CEMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEOJUGI3DKNZXGE>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
I would recommend using git from the command line if you are having issues with the GUI client. The CLI is very well documented and most GUI clients that I have used have weird behavior. The CLI documentation is pretty well organized on git-scm.com I can help with the commit re-naming. Can you provide me with commit messages that I can use. Feel free to just provide them via this GitHub chat. |
|
That is a good suggestion. I will do that next time.
The logs I would like to change would be:
Minor fix: Set max limit for memory allocation when new package/patch is release but not re-open the GUI package.
Minor fix (cont.): Set max limit for memory allocation when new package/patch is release but not re-open the GUI package.
Thank you,
Hao
From: Zachary Roy ***@***.***>
Sent: Tuesday, September 16, 2025 10:14 AM
To: CentralValleyModeling/wrims ***@***.***>
Cc: Xie, ***@***.*** ***@***.***>; Author ***@***.***>
Subject: Re: [CentralValleyModeling/wrims] Feature/pre allocate memory (PR #239)
[https://avatars.githubusercontent.com/u/134561183?s=20&v=4]dwr-zroy left a comment (CentralValleyModeling/wrims#239)<#239 (comment)>
I use Git GUI. It is difficult to modify the log of commit for me. I am wondering if you could help me from your side. Also, it seems I can only debug the code after I commit the code. It seems an issue as many times, my code modifications won’t work but still are committed.
I would reccommend using git from the command line if you are having issues with the GUI client. The CLI is very well documented and most GUI clients that I have used have weird behavior.
I can help with the commit re-naming. Can you provide me with commit messages that I can use. Feel free to just provide them via this GitHub chat.
—
Reply to this email directly, view it on GitHub<#239 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AC7C7KUHHHY5P2XC3HFGDIL3TBAPBAVCNFSM6AAAAACGS4CEMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEOJZGY2TMMBUGM>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
Set the limit for memory allocation when a new package/patch is released, but not when re-opening the GUI package.
be3209d to
b3f693a
Compare
Set max limit for memory allocation when new package/patch is release but not re-open the GUI package.