Test for failure modes on BuildProps#235
Merged
Merged
Conversation
dwr-zroy
commented
Mar 6, 2026
dwr-zroy
commented
Mar 6, 2026
dwr-zroy
commented
Mar 6, 2026
dwr-zroy
commented
Mar 6, 2026
36ef2fb to
bfed8a0
Compare
bfed8a0 to
2f8ddd0
Compare
|
Supports testing failures. Also add a null check on `getVN()`
2f8ddd0 to
5b44412
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Refactors
BuildPropsfor easier test harnessing, and adds a test for the failure to read the build.properties file.