You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This modification does away with Tmux so that you can run this container using a yaml. This PR would require a rebuild of the image favoring the use of yaml to deploy container enabling support of common container orchestration such as portainer and other docker management tools.
One of the reasons why I choose tmux is dst have 2 processes for master and cave world, and each of them have an interactive cli. If run in shell background that maybe not convenient enough to manage the servers?
I'm not very familiar with docker compose, is there any way to cope with the compose problems while maintaining both cli interactive? I'm also checking the compose part now.
I had a discussion with @taoky . Generally we have 4 plans:
A. Current plan, use tmux/screen to detach/attach to manage master/cave world in a single container. Not orthodox but you can attach to master/cave cli and interact
B. Get away with tmux, use docker compose to run master/cave in different container. But we have duplication of 2 copies of steam cli and DST itself.
C. Your PR. But it's less manageable, you cannot attach to bg process as the shell hangs on wait -n
D. Get away with tmux, use socat and nc to manage master/cave (outside the container), but the context could be lost between nc and I think tmux/screen is better
All because DST's way of manage 2 worlds in different process is weird :(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modification does away with Tmux so that you can run this container using a yaml. This PR would require a rebuild of the image favoring the use of yaml to deploy container enabling support of common container orchestration such as portainer and other docker management tools.