Added Default Currency Choice in the Setting#3044
Open
Selinaliu1030 wants to merge 1 commit intoCatimaLoyalty:mainfrom
Open
Added Default Currency Choice in the Setting#3044Selinaliu1030 wants to merge 1 commit intoCatimaLoyalty:mainfrom
Selinaliu1030 wants to merge 1 commit intoCatimaLoyalty:mainfrom
Conversation
Key changes summary: 1. Added a new section "Card creation" in the Setting page 2. Added an entry "Default currency type" with a dropdown menu to choose from 3. Added a get method in Setting.java to get the value of selected default currency type 4. Set the currency type value to selected default in LoyaltyCardEditActivity::onCreate() 5. Added Unit tests and integration tests for the feature Note: The PR has passed all the existing tests and newly added tests --------- Co-authored-by: Rasmus Sjöberg <rasmus.sjoberg15@gmail.com> Co-authored-by: filippaco <filippacolsson@gmail.com> Co-authored-by: Jacob F <jcbfrdrch@gmail.com> Co-authored-by: etisell <etisell@kth.se> Co-authored-by: Emma Tisell <89631117+Emmex03@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #2886
Key changes summary:
Note: The PR has passed all the existing tests and newly added tests