Skip to content

Fix: unified focus behavior across all panels using shared lastRow() - #32

Merged
jsteyn merged 1 commit into
CarpentriesMagic:mainfrom
sahilsanap101:bug-fix
Oct 30, 2025
Merged

Fix: unified focus behavior across all panels using shared lastRow()#32
jsteyn merged 1 commit into
CarpentriesMagic:mainfrom
sahilsanap101:bug-fix

Conversation

@sahilsanap101

Copy link
Copy Markdown
Contributor

This PR fixes the focus jump issue when using "Delete GitHub Repository",
"Generate", and "Clone" buttons.

  • Moved lastRow() into a new shared UIUtils class.
  • Updated all panels to use the common method.
  • Tested across Workshop, Instructor, and Learner tabs.

Fixes: #29

@jsteyn jsteyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you.

@jsteyn
jsteyn merged commit 161ee9b into CarpentriesMagic:main Oct 30, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

minor BUG: release 57 focus jumps when generating workshop websites

2 participants