settlement: per-developer daily withdraw cap#468
Merged
greatest0fallt1me merged 1 commit intoJun 25, 2026
Merged
Conversation
|
@nice-bills Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
a per-developer daily withdraw cap is a clean rate-limit on the settlement side, and sensible defaults too. merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #422
Adds an optional per-developer daily withdrawal cap to withdraw_developer_balance. Admin sets caps via set_daily_withdraw_cap, emits daily_withdraw_cap_changed event. Accumulator resets on timestamp / 86400. Defaults to no limit when unset (cap=0).
Changes
lib.rs — DailyWithdrawCap/WithdrawalToday storage, DailyWithdrawState { day, amount }, DailyWithdrawCapExceeded error, cap enforcement + admin setter + view fns
test.rs — 7 new tests (cap exceeded, day reset, cumulative tracking, per-developer isolation, defaults)
INVARIANTS.md — added rate-limit invariant section