Repository navigation
fix(app): ignore a double tap on a photo that did not complete - #480
Merged
Merged
Conversation
Gesture handler calls onEnd for failed taps too, so a double tap that drifted or lost to a pinch still zoomed in, now on the spot where it was abandoned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gesture handler calls a tap's onEnd for failed taps too, so a double tap that drifted or lost to a pinch still zoomed the photo, and since the double-tap zoom change it zoomed on the spot where the tap was abandoned. The handler now returns early unless the tap succeeded.
Tests: a new ZoomableImage test passes a failed tap and fails without the fix; the existing tap tests now pass success explicitly. app just check passes.