Skip to content

fix(core): fail at once on an encrypted TLS key - #118

Merged
simonvanlierde merged 1 commit into
mainfrom
fix/tls-key-password-and-notes
Oct 27, 2026
Merged

simonvanlierde merged 1 commit into
mainfrom
fix/tls-key-password-and-notes

Conversation

@simonvanlierde

Copy link
Copy Markdown
Contributor

Three small follow-ups to the local HTTPS support in 0.7.2, from a correctness review of the release.

  • A passphrase-protected TLS_KEY_FILE made OpenSSL try to prompt for the password: in the container that failed with a cryptic [Errno 22] Invalid argument, and on a host with a terminal startup would wait at the prompt. validate_tls_files now loads the key with an empty password, so it fails at once with "the key must be unencrypted".
  • The NOTE comments in pyproject.toml still said the image runs fastapi run; it runs app/serve.py since 0.7.2.
  • INSTALL says the key must be unencrypted, and that the TLS settings belong in the .env next to compose.yml, so the container's healthcheck sees them too.

Tests: the new encrypted-key test failed with the [Errno 22] message before the change. just check passes (946 passed).

- validate_tls_files loads the key with an empty password, so a passphrase-protected key stops startup with a message instead of OpenSSL prompting for one
- the pyproject notes say the image runs app/serve.py, not fastapi run
- INSTALL says the key must be unencrypted and the TLS settings belong in the .env Compose reads, so the healthcheck sees them

Signed-off-by: Simon van Lierde <simonvanlierde@gmail.com>
@codspeed

codspeed Bot commented Oct 27, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

1 warning

⚠️ 4 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 12 untouched benchmarks


Comparing fix/tls-key-password-and-notes (0ba2bd4) with main (f89df2a)

Open in CodSpeed

@simonvanlierde
simonvanlierde merged commit de3a04d into main Oct 27, 2026
15 checks passed
@simonvanlierde
simonvanlierde deleted the fix/tls-key-password-and-notes branch October 27, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant