[simonvanlierde]

This keeps the backend's real image id when its upload reply has a valid image_id but a bad or missing image_url. Before, the whole reply was dropped and the sink fell back to the Pi's local capture id.

• upload_image returned UploadedImageInfo(image_id=None, image_url=None) for any invalid reply, so BackendPushSink.put used the local id.
• It now checks the validation errors from DeviceImageUploadAck: if none are on image_id, the id is kept and only the URL is dropped. An invalid id is still dropped.
• Also renames _API_PORT to API_PORT in app/pairing/routers, since another module imports it. No behaviour change.

Tests: just check passes (918 passed, 1 skipped). The new test for a valid id with a bad URL failed before the fix with assert None == 'server-abc'. Not tried against a real backend.

[codspeed]

Merging this PR will not alter performance

1 warning

⚠️ 4 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 12 untouched benchmarks

---

_{Comparing fix/keep-backend-image-id (43cf435) with main (85158d9)¹}

Footnotes

1. No successful run was found on main (64bad1b) during the generation of this report, so 85158d9 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩