Password forgotten notification - #112
Merged
gburton merged 5 commits intoAug 20, 2026
Merged
Conversation
Converting password forgotten to a notification module.
Converting password forgotten to notification module.
Language file for new password forgotten notification module.
Controller file for new Password Forgotten notification module.
Template file for new Password Forgotten notification module.
Contributor
|
Thank You @blaine-cwe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain the details for making this change. What existing problem does it solve?
#111
Currently, the password_forgotten.php script uses a hardcoded email generation routine directly in the root file. This makes it impossible for shop owners to customize, heavily style, or convert the password reset email to HTML without modifying core files.
This proposal updates password_forgotten.php to route the reset email through the existing Notifications::notify() system. This brings the password reset architecture completely in line with the modern "Create Account" and "Order Update" modular notification systems.
Test plan (required)
Baseline Test: On a stock 1.1.0.7 install, trigger a password reset. Observe the standard plain-text email arrives via the hardcoded root file routine.
Apply Changes:
Core Verification: Trigger another password reset. Observe that the exact same plain-text email arrives, proving the module perfectly replicates core functionality.
Override Verification: Install a custom/3rd-party HTML notification module mapped to the password_forgotten trigger. Run the reset form again and observe that the custom HTML email is delivered without any further core modifications.