fix: Include target_url in GitHub status for timed-out tests #1005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a test times out due to exceeding the maximum runtime limit, the GitHub status was set to ERROR but without a target_url. This made it impossible for users to click through to see what happened - they would just see "ERROR" with no link. Root cause: In delete_expired_instances(), update_status_on_github() was called without the target_url parameter, which resulted in GitHub displaying a null/empty URL. Fix: Build the target_url (using url_for with fallback for non-request context) and pass it to update_status_on_github() so users can navigate to the test page to see results even when a test times out. Discovered while investigating why CCExtractor/ccextractor#2007 Linux test showed ERROR on GitHub with no clickable link. Test #7736 had run for ~4 hours, executed 116 regression tests (105 failed), but was canceled due to time limit. The test page existed and showed results, but GitHub had no link to it. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
cfsmp3
requested review from
canihavesomecoffee and
thealphadollar
as code owners
|
canihavesomecoffee
approved these changes
Jan 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a test times out due to exceeding the maximum runtime limit, the GitHub status was set to ERROR but without a
target_url. This made it impossible for users to click through to see what happened - they would just see "ERROR" with no link.Root cause: In
delete_expired_instances(),update_status_on_github()was called without thetarget_urlparameter:Fix: Build the
target_url(usingurl_forwith fallback for non-request context) and pass it toupdate_status_on_github().Investigation Details
Discovered while investigating why CCExtractor/ccextractor#2007 Linux test showed ERROR on GitHub with no clickable link.
What happened:
target_url: nullGitHub API response showing the bug:
{ "context": "CI - linux", "created_at": "2026-01-10T14:20:04Z", "description": "Could not complete test, time limit exceeded", "state": "error", "target_url": null // <-- This should be the test URL! }Changes
target_urlparameter when callingupdate_status_on_github()indelete_expired_instances()target_urlis includedTest plan
test_delete_expired_instances_includes_target_urlpassestest_delete_expired_instancesstill passes🤖 Generated with Claude Code