[charts/portal] Added option for disabling tls on portal ingress#458
Open
alec-pinson wants to merge 2 commits into
Open
[charts/portal] Added option for disabling tls on portal ingress#458alec-pinson wants to merge 2 commits into
alec-pinson wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Added option to disable tls on the portal ingress rule.
Benefits
Our ingress controller already has a wildcard certificate applied to it. So we don't want to enable tls on the ingress rule.
Drawbacks
None, optional on/off toggle which keeps previous behaviour as default.
Applicable issues
None created
Additional information
Checklist
Chart.yamlaccording to semver.[charts/gateway])values-production.yamlapart fromvalues.yaml, ensure that you implement the changes in both files