Enhance is_detector to include OBSERVER type#231
Open
chadspratt wants to merge 2 commits intoBurnySc2:developfrom
Open
Enhance is_detector to include OBSERVER type#231chadspratt wants to merge 2 commits intoBurnySc2:developfrom
chadspratt wants to merge 2 commits intoBurnySc2:developfrom
Conversation
observers are always ready but because they are cloaked build_progress == 0 unless they are detected
Owner
|
Perhaps a better suggestion would be to split the set of detectors into mobile detectors, static detectors (here: buildings, not OBSERVERSIEGE), then check
|
Author
|
As far as i know, the only detectors that can be cloaked are the observer and a photon cannon via mothership. A cloaked photon cannon could be unfinished or unpowered, so the only unit that is guaranteed to be a ready detector is the observer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
observers are always ready, but build_progress == 0 unless they are detected.
I considered changing is_ready but build_progress can be < 1 if a mothership is cloaking a warp-in so it would need to specify all the non-warpin units for that to work. That would be more correct for immortals/disruptors/etc that are always ready if they exist but it seemed more fraught.