Make _prepare_step async and add Unit.abilities#163
Draft
Make _prepare_step async and add Unit.abilities#163
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #163 +/- ##
===========================================
- Coverage 60.16% 60.15% -0.01%
===========================================
Files 107 107
Lines 13974 14011 +37
===========================================
+ Hits 8408 8429 +21
- Misses 5566 5582 +16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #157
This PR adds the
Unit.abilitiesproperty which returns a set of AbilityId for all own units. Returns an empty set and a warning for neutral and enemy units.This is useful so you don't have to handle querying abilities yourself, to check if tech requirement is met or if an ability is on cooldown (e.g. blink). However this sends one query to the API on each iteration before
on_stepis called.