misc fixes to updatable proposals - #996
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe PR adds testnet badges to DAO displays, role badges to member cards, queue guidance, auction-owner loading feedback, and founder allocation layout adjustments. ChangesDAO status and proposal feedback
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
packages/create-proposal-ui/src/components/Queue/Queue.tsxESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox. packages/create-proposal-ui/src/components/TransactionForm/MintGovernanceTokens/MintGovernanceTokens.tsxESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox. packages/dao-ui/src/components/AdminForm/AdminFounderAllocationFields.tsxESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
packages/create-proposal-ui/src/components/TransactionForm/MintGovernanceTokens/MintGovernanceTokens.tsx (1)
135-141: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winExpose the loading state to assistive technology.
This branch renders only a visual spinner. It provides no text,
role, or accessible label. Screen-reader users receive no loading status while the form is replaced.Add a semantic status container. Confirm that
Stackforwards ARIA attributes in the installed Zord version.Proposed fix
return ( - <Stack> - <Spinner />{' '} + <Stack role="status" aria-label="Loading auction owner"> + <Spinner /> </Stack> )🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/create-proposal-ui/src/components/TransactionForm/MintGovernanceTokens/MintGovernanceTokens.tsx` around lines 135 - 141, Update the isLoading branch in MintGovernanceTokens to expose a semantic loading status for assistive technology, adding an appropriate role and accessible label or text while preserving the existing spinner layout. Confirm that the Zord Stack component forwards the required ARIA attributes; if it does not, use a compatible semantic container instead.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/create-proposal-ui/src/components/Queue/Queue.tsx`:
- Around line 106-114: Update the queue guidance panel condition in Queue so it
renders only when the queue contains at least one removable transaction,
excluding disabled UPGRADE and UPDATE_MINTER entries. Reuse the existing
transaction type and disabled-state logic from the queue cards, while preserving
the current message for queues with removable entries.
In `@packages/dao-ui/src/components/AdminForm/AdminFounderAllocationFields.tsx`:
- Around line 99-107: Add an accessible aria-label to the Button invoking
removeFounderAddress in the founder allocation fields, including the one-based
allocation index so screen readers identify which founder allocation will be
removed.
- Around line 103-104: Update the remove-button positioning near the
AdminFounderAllocationFields layout to eliminate the fixed bottom: 52 offset.
Anchor the button using the row’s layout, such as a suitable flex/grid alignment
or a relative container with a stable edge, so it remains aligned with
SmartInput and DatePicker when validation errors expand their height and across
responsive states.
---
Nitpick comments:
In
`@packages/create-proposal-ui/src/components/TransactionForm/MintGovernanceTokens/MintGovernanceTokens.tsx`:
- Around line 135-141: Update the isLoading branch in MintGovernanceTokens to
expose a semantic loading status for assistive technology, adding an appropriate
role and accessible label or text while preserving the existing spinner layout.
Confirm that the Zord Stack component forwards the required ARIA attributes; if
it does not, use a compatible semantic container instead.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: c7cb85a9-56af-459e-915b-325153abec8a
📒 Files selected for processing (10)
apps/web/src/components/ProfileDaoList.tsxapps/web/src/layouts/DefaultLayout/NavMenu/ProfileMenu.tsxapps/web/src/styles/profile.css.tspackages/create-proposal-ui/src/components/Queue/Queue.css.tspackages/create-proposal-ui/src/components/Queue/Queue.tsxpackages/create-proposal-ui/src/components/TransactionForm/MintGovernanceTokens/MintGovernanceTokens.tsxpackages/dao-ui/src/components/AdminForm/AdminFounderAllocationFields.tsxpackages/dao-ui/src/components/MembersList/MemberListCard.test.tsxpackages/dao-ui/src/components/MembersList/MemberListCard.tsxpackages/dao-ui/src/components/MembersList/MembersList.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Bug Fixes
Tests