Skip to content

Fro 316 confidence is not updating when changing the evaluation of a #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bob-six merged 2 commits into from
Sep 29, 2025
Merged

Fro 316 confidence is not updating when changing the evaluation of a #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2676557
feat: added invalidating tags when a new evaluation is applied
Bob-six Sep 29, 2025
996485c
fix: added global invalidation tag when a new evaluation comes in
Bob-six Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/ConnectionAndEvaluationStatus.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ export const ConnectionAndEvaluationStatus = ({
myConnectionToSubject: inboundConnectionInfo,
myConfidenceValueInThisSubjectRating: confidenceValue,
} = useMyEvaluationsContext({ subjectId });

const authData = useSelector(selectAuthData);

const impactPercentage = useImpactPercentage(auraImpacts, authData?.brightId);
Expand Down
4 changes: 4 additions & 0 deletions src/components/EvaluationFlow/EvaluationFlow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ import { useCallback, useEffect, useState } from 'react';
import useViewMode from '../../hooks/useViewMode';
import { EvaluationCategory, PreferredView } from '../../types/dashboard';
import { Dialog, DialogContent, DialogHeader, DialogTitle } from '../ui/dialog';
import { useDispatch } from '@/store/hooks';
import { connectionsApi } from '@/store/api/connections';
import { profileApi } from '@/store/api/profile';

const EvaluationFlow = ({
showEvaluationFlow,
Expand Down Expand Up @@ -40,6 +43,7 @@ const EvaluationFlow = ({
const onSubmitted = useCallback(
async (newRating: number | null | undefined) => {
const myRatingsCount = myRatings?.filter((r) => Number(r.rating)).length;

refreshInboundRatings();
refreshOutboundRatings();
if (!newRating) {
Expand Down
11 changes: 9 additions & 2 deletions src/components/EvaluationOpNotifications.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,11 @@ import {
} from '../constants';
import { useRefreshEvaluationsContext } from '../contexts/RefreshEvaluationsContext';
import { useSubjectName } from '../hooks/useSubjectName';
import { useSelector } from '../store/hooks';
import { useDispatch, useSelector } from '../store/hooks';
import BrightIdProfilePicture from './BrightIdProfilePicture';
import EvaluationThumb from './Shared/EvaluationThumb';
import { connectionsApi } from '@/store/api/connections';
import { profileApi } from '@/store/api/profile';

type EvaluateOpNotificationData = {
text: string;
Expand Down Expand Up @@ -106,6 +108,7 @@ export default function EvaluationOpNotifications() {
const operations = useSelector(selectEvaluateOperations);

const prevOperationsRef = useRef<EvaluateSubmittedOperation[] | null>(null);
const dispatch = useDispatch();

useEffect(() => {
const storedOperations = localStorage.getItem('prevOperations');
Expand Down Expand Up @@ -166,6 +169,10 @@ export default function EvaluationOpNotifications() {
prevOperation.state !== operation_states.APPLIED &&
operation.state === operation_states.APPLIED
) {
dispatch(connectionsApi.util.invalidateTags([{ type: 'BrightID' }]));

dispatch(profileApi.util.invalidateTags([{ type: 'BrightID' }]));

addNotification({
operation,
text: `Applied!`,
Expand All @@ -186,7 +193,7 @@ export default function EvaluationOpNotifications() {
// Update ref and localStorage with the latest operations
prevOperationsRef.current = operations;
localStorage.setItem('prevOperations', JSON.stringify(operations));
}, [addNotification, operations, refreshEvaluations]);
}, [addNotification, operations, refreshEvaluations, dispatch]);

return (
<div className="w-full">
Expand Down
Loading