fix(weekly-agenda): don't tell owners their pre-drafted section is 'missing'#140
Open
BreadrichEngels wants to merge 1 commit into
Open
fix(weekly-agenda): don't tell owners their pre-drafted section is 'missing'#140BreadrichEngels wants to merge 1 commit into
BreadrichEngels wants to merge 1 commit into
Conversation
…issing' The nudge + escalation copy claimed "I don't have your agenda section yet" and "time to fill in your section" — but the weekly build ALWAYS pre-drafts every owner's section from GitHub. So owners who simply hadn't *confirmed* their (already-populated) section were told, in-channel, that their entries were missing. Reword the ask + escalation to ask owners to review/confirm/correct their drafted section instead of implying it's empty. Detection + nudge ladder behaviour unchanged. Adds a regression test that the escalation never claims the section is missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
What: Fix the weekly-agenda flow's owner-nudge + escalation copy so it stops telling owners their agenda section is "missing" when it isn't.
Why: The weekly build always pre-drafts every owner's section from GitHub (their merged PRs / closed issues, or a "— space for 's update —" invite). But "responded" is tracked solely by the existence of
inputs/<week>/<slug>.md, which is written only when the owner replies to confirm. So an owner who simply hadn't confirmed their already-populated section got escalated in #core-team-chat with "📝 I don't have 's agenda section for yet" — telling people their present entries were gone. It hit 7 owners for the 2026-07-01 cycle.How: Reword
escalationPostandaskTextto ask owners to review / confirm / correct their drafted section instead of implying it's empty. No change to detection or the nudge ladder — purely accurate copy. Added a regression test asserting the escalation never claims the section is missing (/I don't have/) and does ask for confirmation.Tested:
npx vitest run profiles/example/plugins/__tests__/weekly-agenda.test.mjs→ 27 passed (incl. the new assertions).cc @RonTuretzky — requesting your review; you own this flow.