Align access-control docs/config with the flat permission model (remove admin-tier leftovers) - #100
Open
BreadrichEngels wants to merge 1 commit into
Open
Align access-control docs/config with the flat permission model (remove admin-tier leftovers)#100BreadrichEngels wants to merge 1 commit into
BreadrichEngels wants to merge 1 commit into
Conversation
The permission hierarchy was flattened (one tier: allowlisted user = full access) but schema/architecture.md still documented the old 4-tier RBAC (Superadmin/Admin/Coordinator/Resident + tag hierarchy), and the example deploy.env presented KB_ADMINS/KB_SUPERADMINS as a generic 'admin usernames' knob. Rewrites the RBAC section to the flat model, keeps KB_SUPERADMINS framed as the single remaining gate (the /admin credentials page), and flags the dashboard's lingering KB_ADMINS/KB_COORDINATORS/KB_RESIDENTS tiers as legacy to be flattened (tracked). Docs/config only — no runtime behavior change.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
What — Removes the leftover admin/role-tier identity language from the framework docs + example config so they match the already-shipped flat permission model.
Why — The CHANGELOG records "Flattened the permission hierarchy … the four-tier role model (Superadmin / Admin / Coordinator / Contributor / Guest) … are gone. There is now exactly one tier." But
schema/architecture.mdstill documented the old 4-tier RBAC + tag hierarchy, andprofiles/example/deploy.envframedKB_ADMINS/KB_SUPERADMINSas generic "admin usernames." That's stale and misleading.Changes (docs/config only — no runtime behavior change):
schema/architecture.md: rewrote theRBACsection →Access control (flat model). Flat model is authoritative;KB_SUPERADMINSframed as the one remaining gate (the/admincredentials page, which exposes secrets). Added a> Legacynote that the KB dashboard code still readsKB_ADMINS / KB_COORDINATORS / KB_RESIDENTSand renders the old tiers.profiles/example/deploy.env: reworded the comment to the flat model; keepsKB_SUPERADMINS(credentials gate) and notesKB_ADMINSis legacy.This PR is docs/config only. The substantive other half is flattening the KB dashboard code (
kb-ui/server.mjs+kb-ui/roster.mjs), which still implements the 4 tiers (isAdmin/isCoordinator/isResident/isSuperAdmin) and uses them to gate real access — viewing all docs / personnel notes (line ~142, ~1214),/logs(~1558),/architecture(~1801), edit (~2565), non-private access (~1242), and/admincredentials (~1650, keep).Flattening those to "authenticated user = full access,
KB_SUPERADMINSkeeps only/admin" broadens dashboard access (e.g. a former "resident" would see all docs). That's consistent with the flat model but is a deliberate, security-relevant change in untested server code, so I didn't bundle it here blind. @RonTuretzky — want me to do that kb-ui flattening as a follow-up PR? Happy to, just want your nod on the access-broadening first.Related: #98 (populate the breadchain profile — the host-local CLAUDE.md still has the placeholder admin identities), #99 (escalation rework).
For Skills