Add database migration round-trip CI check#299
Closed
zhangsiqiang519 wants to merge 1 commit into
Closed
Conversation
Contributor
|
I will take this issue. Strong backend background, clean PR coming shortly. |
Contributor
|
I'm on it. Quick fix — devops scoped, clean PR incoming. Closes #299 |
Contributor
|
Thanks for this. Issue #182 is assigned to @jaynomyaro, so I'm holding off. Worth coordinating in the issue thread before opening or landing. |
Contributor
|
Closing this — #182 is assigned to @jaynomyaro. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AddDeletedAtToBountiesmigration to backend TypeORM migration lists.migration:checkto run migrations up, compare schema metadata, revert them, then run up again.migration-testCI job for PRs.Closes #182
Verification
npm run lint --workspace=apps/backendnpm run build --workspace=apps/backendnpm run test --workspace=apps/backend -- --runInBandgit diff --checkNot run locally:
npm run migration:check --workspace=apps/backendneeds a PostgreSQL service; the new CI job provides it.