feat(#174): emit events on all bounty lifecycle transitions#286
Closed
GBOYEE wants to merge 4 commits into
Closed
Conversation
- Add env.events().publish() to initialize, fund, start_work, submit, approve, cancel
- Events use consistent topic shape: (symbol_short!("event_name"), actor_address)
- Event data includes new BountyStatus and relevant amounts/addresses
- Events emitted before final storage write
- Add 4 unit tests verifying event emission
- Add docs/events.md with full event schema for indexer developers
Closes BountyOnChain#174
- execute_approve: read owner from storage before event publish - execute_cancel: move owner declaration outside if block for else branch - Fix test initialize calls: add missing timelock_duration arg (5 params now) All 35 tests pass. Clippy clean.
Contributor
Author
|
CI fully green (Frontend ✅ Backend ✅ Contracts ✅ Security Audit ✅ E2E ✅ Trivy ✅). Emits events on all 6 bounty lifecycle transitions (initialize, fund, start_work, submit, approve, cancel). Includes 4 new unit tests (35 total pass). Clippy clean. Ready for merge review! 🚀 |
Contributor
Author
|
📋 Paper Trail — Implemented as part of GrantFox OSS campaign. Event emission on all 6 bounty lifecycle transitions. CI fully green. Requesting reward review if eligible. |
Contributor
|
Hey 👋 Lifecycle event emission opens up downstream integrations nicely. Merging. 🚀 |
Contributor
|
Heads up — sorry for the noise: the merge got blocked once sibling PRs landed. Your fork looks like it doesn't allow maintainer writes, so could you rebase this onto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed in favor of rebased version #305