API Scaffolding#8
Merged
Merged
Conversation
Collaborator
|
This is good stuff. Although I noticed the file structure is now: I think I'm missing why this is necessary and we can't just have routes be stored in the app directory base. |
Collaborator
Author
|
Oh whoops, ill fix that lmao |
Collaborator
Author
|
Adjusted paths, feel free to merge if you deem ready @KarlFarrar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the way we're instantiating FastAPI to the app builder method, added a health check and integrated with existing tests. Also added two requirements files- one for general API requirements, and another for dev/tests.