Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds baseline documentation and configuration files intended to support AI-assisted workflows (Claude Code) alongside the existing dAppBooster template, plus local-ignore rules for Claude-specific files.
Changes:
- Add
CLAUDE.mdwith repo setup, architecture, conventions, and testing guidance. - Add Claude Code configuration (
.claude/settings.json) and ignore local Claude artifacts via.gitignore. - Add
AGENTS.mdpointing atCLAUDE.md(likely as a symlink-style pointer).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
CLAUDE.md |
Adds repo “operator’s manual” covering setup, structure, conventions, and patterns. |
AGENTS.md |
Adds an agent entry pointing to CLAUDE.md (potentially via symlink representation). |
.gitignore |
Ignores Claude Code local settings and local CLAUDE notes. |
.claude/settings.json |
Allows web fetch access to specific documentation domains. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…r file Replace the literal pipe character between the two URLs in the header with a space separator to avoid Markdown table syntax confusion. Convert AGENTS.md from a symlink to a regular file copy of CLAUDE.md so it works reliably on Windows and in CI environments where symlinks may not be supported.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add test safety net before dependency updates. New files: - src/test-utils.tsx: renderWithProviders, createMockWeb3Status, createMockChain - src/utils/strings.test.ts: truncateStringInTheMiddle and getTruncatedHash (13 tests) - src/utils/getExplorerLink.test.ts: getExplorerLink (6 tests) - src/utils/address.test.ts: isNativeToken (5 tests) - src/env.test.ts: Zod-validated env schema (9 tests) - .env.test: Vitest environment variables for required PUBLIC_ fields
- Fix env.test.ts test names that incorrectly claimed to test defaults while .env.test was setting those vars explicitly - Assert exact value for PUBLIC_WALLETCONNECT_PROJECT_ID (was typeof check) - Fix createMockWeb3Status shape to match actual Web3Status interface (was using isConnected/chainId/publicClient; hook uses isWalletConnected/ walletChainId/readOnlyClient) - Hardcode expected explorer URL in getExplorerLink assertions instead of deriving from mock chain (prevents false positives if mock misconfigured)
BigNumberInput: add 9 tests covering placeholder, disabled state, onChange with parsed bigint, onError for min/max violations, decimal precision enforcement, and input clearing. HashInput: add 7 tests covering placeholder, typed value reflection, initial value, clear to null, debounced search callback, onLoading lifecycle, and custom renderInput.
- Rename misleading test names in BigNumberInput (onError absence test, maxUint256 constraint test) - Add beforeEach mock clear in HashInput to prevent cross-test contamination from unconsumed mockResolvedValueOnce calls - Add debounceTime: 0 to clear test to avoid real-timer dependency - Rename debounce test to accurately describe what it covers; fake-timer debounce testing conflicts with waitFor + userEvent in jsdom
- Use @/src/env alias import in env.test.ts (matches repo convention) - Rename 'checksummed zero address' test to 'zero address string literal' (no checksum casing difference in this value; name was misleading)
React global namespace is not available without explicit import; use named import from 'react' to avoid 'Cannot find namespace React' errors.
- useWeb3Status.test.ts: 8 tests covering disconnected/connected state, isWalletSynced, switchingChain, disconnect, switchChain, appChainId - useWeb3StatusConnected.test.ts: 2 tests (co-located in same file) covering throw-on-disconnect and pass-through when connected - useErc20Balance.test.ts: 5 tests covering missing address/token, native token skip, successful balance fetch, and error handling - useTokenLists.test.ts: 4 tests covering return shape, deduplication, native token injection, and schema validation filtering
- Add beforeEach mock clearing in useWeb3Status to prevent shared mock call history leaking between tests - Switch mockReturnValue to mockReturnValueOnce for the connected test in useWeb3StatusConnected (hook calls useWeb3Status twice internally) - Add beforeEach mockReadContract.mockClear() in useErc20Balance to prevent cross-test false negatives on not.toHaveBeenCalled assertions
New tests for shared components and utilities: - TokenLogo: img src/alt/size, IPFS URL conversion, placeholder on error - TransactionButton: wallet states, pending label, onMined callback - SwitchNetwork: network display, disabled state, menu item rendering - WalletStatusVerifier: connect fallback, wrong chain, synced renders children - withWalletStatusVerifier HOC: fallback and pass-through behavior - withSuspense/withSuspenseAndRetry: Suspense fallback, error message, retry Also adds: - ResizeObserver mock to setupTests.ts (required by @floating-ui in jsdom) - .env.test and src/test-utils.tsx (shared test utilities from tier 1)
- setupTests.ts: replace vi.fn() ResizeObserver with a real class guarded by a conditional check — vi.restoreAllMocks() can no longer clear it - suspenseWrapper.test.tsx: restore only the console.error spy in afterEach instead of vi.restoreAllMocks() which would wipe the ResizeObserver polyfill - TransactionButton.test.tsx: make useWaitForTransactionReceipt mock hash-aware so it only returns the receipt when called with the expected hash
Smoke tests for all demo page components to verify they render without crashing. Mocks external Web3 deps at module level. New test files: - home/index.test.tsx: Home renders Welcome + Examples sections - NotFound404.test.tsx: 404 page with mocked useNavigate - demos/ConnectWallet/index.test.tsx: mocked ConnectWalletButton - demos/EnsName/index.test.tsx: mocked useEnsName - demos/HashHandling/index.test.tsx: mocked useWeb3Status + detectHash - demos/SignMessage/index.test.tsx: shows fallback when wallet absent - demos/SwitchNetwork/index.test.tsx: shows fallback when wallet absent - demos/TransactionButton/index.test.tsx: shows fallback when wallet absent - demos/TokenDropdown/index.test.tsx: mocked BaseTokenDropdown - demos/TokenInput/index.test.tsx: mocked useTokenLists + useTokenSearch Also adds .env.test and src/test-utils.tsx (shared test utilities).
The module exports detectHash as a default export; the mock only provided a named export so HashInput would receive undefined and throw on invocation. Added both default and named exports to the mock factory.
fix(seo): JSON-LD structured data and sitemap hostname
fix(security): CSP report-only and security headers
chore(deps): update minor and patch dependencies
…plorer fix: throw when getExplorerLink has no block explorer URL available
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 45 out of 47 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch adds AI agent context files (CLAUDE.md / AGENTS.md) and serves as the destination branch for a complete web quality initiative: a test safety net (5 PRs) followed by a web audit fix chain (5 PRs), all stacked incrementally so tests catch any regressions introduced by fixes.
This branch
CLAUDE.md+AGENTS.md— project instructions for AI agents (Claude and others). Both files are kept in sync; AGENTS.md is a regular file copy of CLAUDE.md..claude/— Claude Code settings and ignore rulesStacked PR chain (merge in order)
Test safety net
test/utilsfeat/ai-integrationtest/enhance-existingtest/utilstest/hookstest/enhance-existingtest/componentstest/hookstest/demo-smoketest/componentsWeb quality fixes (stacked on top of tests)
fix/a11ytest/demo-smokefix/performancefix/a11yfix/seofix/performancefix/securityfix/seofix/depsfix/securityWhat was fixed
Accessibility
#cc0→#996600(light) /#e6b800(dark) — was 1.3:1 contrast, now ~6-7:1aria-invalidadded to BigNumberInput on validation error_focusVisiblefocus rings restored on CopyButton and ExternalLink (previouslyoutline: none)aria-labeladded to all icon-only buttons (close buttons, explorer links)Performance
loading="lazy"on TokenLogo and Avatar imagesmanualChunksfor React, wagmi/viem, TanStack, Chakra UI, and AppKit vendor bundlesSEO
PUBLIC_APP_URLenv var with fallbackSecurity
Content-Security-Policy-Report-Onlyheader in vercel.json (non-breaking, report-only mode)X-Content-Type-Options: nosniff,X-Frame-Options: DENY,Referrer-Policy: strict-origin-when-cross-originDependencies
Merge order
#415 → #416 → #417 → #418 → #419 → #421 → #422 → #423 → #424 → #425 → #420 (into main)
Test plan
pnpm test:coverageconfirms no regressionspnpm buildpasses cleanly