ImageGen spend confirm + CHANGELOG for #86 (3.29.4) - #88
Merged
Conversation
ImageGen had no spend confirmation after the media-router removal (#86) — the router proposal was its only AskUser path. Add a pure price-math, model-aware Generate/Cancel confirm (parity with VideoGen): interactive callers see the model + estimated cost before any USDC is spent; direct callers (desktop, no onAskUser) generate immediately. Also document #86 in the CHANGELOG (3.29.4), including the upgrade note that cloud sync is now opt-in (FRANKLIN_CLOUD_SYNC=on).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #86 (pure media tools).
Generate/Cancelconfirm — parity with VideoGen. Interactive callers (CLI/agent) see the model + estimated cost before any USDC is spent; direct callers (desktop, noonAskUser) generate immediately.estimateCostUsd(findModel(model))so the price matches the named model instead of a flat per-second rate.FRANKLIN_CLOUD_SYNC=on); users relying on cross-device sync must set it to keep syncing.Why
#86 merged without a CHANGELOG entry and left an asymmetry: video confirms spend, image didn't. For an agent whose whole pitch is spending your USDC, silent image spend is the wrong default.
Verified
npm run buildclean; 454 local tests pass.