Skip to content

feat: accept certificate name on fellowship application (write-through to user.name) #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theanmolsharma merged 1 commit into from
Jul 2, 2026
Merged

feat: accept certificate name on fellowship application (write-through to user.name) #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/fellowship-applications/fellowship-applications.request.dto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,15 @@ export class ProposalFieldsDto {
@IsString()
@MaxLength(255)
location?: string;

// Profile field: the applicant's name used on the certificate. Written
// through to `user.name` rather than stored on the application (see
// service), so it is never duplicated. Mirrors `location`.
@IsOptional()
@Transform(trim)
@IsString()
@MaxLength(255)
name?: string;
}

export class CreateFellowshipApplicationRequestDto extends ProposalFieldsDto {
Expand Down
4 changes: 4 additions & 0 deletions src/fellowship-applications/fellowship-applications.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,10 @@
user.location = emptyToNull(dto.location);
changed = true;
}
if (dto.name !== undefined) {
user.name = emptyToNull(dto.name);
changed = true;
}
if (dto.github !== undefined) {
const handle = emptyToNull(dto.github);
user.githubProfileUrl = handle
Expand Down Expand Up @@ -650,7 +654,7 @@
await this.documentsService.provisionAcceptedApplication(
application,
reviewer,
file!,

Check warning on line 657 in src/fellowship-applications/fellowship-applications.service.ts

View workflow job for this annotation

GitHub Actions / check-formatting-and-lint 

Forbidden non-null assertion

Check warning on line 657 in src/fellowship-applications/fellowship-applications.service.ts

View workflow job for this annotation

GitHub Actions / check-formatting-and-lint 

Forbidden non-null assertion
);
acceptedFellowshipId = fellowship.id;
} else {
Expand All @@ -665,7 +669,7 @@
applicant.email,
applicant.displayName,
application.type,
acceptedFellowshipId!,

Check warning on line 672 in src/fellowship-applications/fellowship-applications.service.ts

View workflow job for this annotation

GitHub Actions / check-formatting-and-lint 

Forbidden non-null assertion

Check warning on line 672 in src/fellowship-applications/fellowship-applications.service.ts

View workflow job for this annotation

GitHub Actions / check-formatting-and-lint 

Forbidden non-null assertion
);
} else if (
dto.status === FellowshipApplicationStatus.REJECTED
Expand Down
Loading