Skip to content

test: align release signing boundary with exact nanopb bounds #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
BitHighlander wants to merge 1 commit into
base: rehearsal/7143-715-host-base
Choose a base branch
from
Draft

test: align release signing boundary with exact nanopb bounds #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/test_msg_signing_boundaries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ def observe_response(request, message):
self.client.call_raw(proto.ClearSession())

def test_multisig_signature_over_72_bytes_is_rejected(self):
"""A decoder-sized 74-byte signature must never reach serialization."""
"""An oversized signature must fail decoding and terminate signing."""
self.requires_firmware("7.14.2")
self.setup_mnemonic_nopin_nopassphrase()
node = ckd_public.deserialize(self.XPUB)
Expand Down Expand Up @@ -181,7 +181,8 @@ def test_multisig_signature_over_72_bytes_is_rejected(self):
tx=proto_types.TransactionType(inputs=[tx_input])
))
self.assertIsInstance(rejected, proto.Failure)
self.assertEqual(rejected.code, proto_types.Failure_SyntaxError)
self.assertEqual(rejected.code, proto_types.Failure_UnexpectedMessage)
self.assertEqual(rejected.message, "Could not parse protocol buffer message")
self._assert_late_txack_rejected()

def test_clear_session_aborts_active_bitcoin_signing(self):
Expand Down