promote: staged 7.16 alpha feature delta to develop - #626
Merged
Conversation
Third-party verifiers keep failing KeepKey reproducibility checks by hashing the freshly built binary (zeroed signature slots in its 256-byte KPKY header) against the signed release's payload hash — an apples-to-oranges comparison that can never match (#433, and the same confusion in 2021's #283). scripts/build/verify-repro.sh makes the correct comparison a single command: clean clone at the tag, official Docker build, download of the signed release asset, and payload-hash (tail -c +257) comparison on both sides, printing all four hashes and PASS/FAIL. docs/ReproducibleBuilds.md documents the header layout, why full-file hashes never match by construction, the manual steps, and the on-device cross-checks (Features.revision, Features.firmware_hash).
…s-check - error out on unrecognized/mistyped flags (e.g. --local=x) instead of silently ignoring them and falling through to the download-and-compare path, which could print a false PASS for a binary that was never read - docs: Features.firmware_hash covers the full signed file (header + payload, per memory_firmware_hash()), not the payload alone — the doc previously implied it matched the payload hash, which never matches
…tals feat(clearsign): decode certified Portals native swaps
…-20260827 rehearsal: roll audited develop and remaining 7.16 alpha PRs together
Owner
Author
|
Final exact-head disposition for alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the exact alpha head produced by fully gated roll-up #625 into fork
develop.Delta from current develop is focused to the remaining 7.16 feature set: Solana display disclosure hardening, canonical structured EIP-712 review, reproducible-build verification, and the unified exact python-keepkey pin. The audited 7.16 baseline from #621 is already in both histories.
Source alpha merge:
cf1a653148119cbfe87b4d171cd00ddfa1b747fb.Tested roll-up parent:
c6e9c08e6fe973826039762924e7f084d64c10fe.Companion exact pin:
2ed835472cb9c2308a729e7ff8ccfb050fa16312(reachable through companion develop mergea395561d8b00caadbedcf6f8d9d7c628a7ca9783).Merge is gated on a fresh exact-head firmware matrix. No signing or release is authorized.