refactor: replace manual call_data parsers with metadata-driven decoding#221
Closed
refactor: replace manual call_data parsers with metadata-driven decoding#221
Conversation
Use scale_value::scale::decode_as_type() with the metadata type registry to generically decode any call_data against the RuntimeCall type. This eliminates ~400 lines of hardcoded per-method parsers (parse_transfer_args, parse_bond_args, parse_proxy_args, etc.) and replaces them with ~150 lines of generic Value-to-JSON conversion. The no-metadata fallback now returns raw hex args since we cannot decode without type info. In practice, metadata is always provided. BTC-3062
lcovar
force-pushed
the
BTC-3062/metadata-driven-parser
branch
from
12a5e65 to
eb0ad7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use scale_value::scale::decode_as_type() with the metadata type registry to generically decode any call_data against the RuntimeCall type. This eliminates ~400 lines of hardcoded per-method parsers (parse_transfer_args, parse_bond_args, parse_proxy_args, etc.) and replaces them with ~150 lines of generic Value-to-JSON conversion.
The no-metadata fallback now returns raw hex args since we cannot decode without type info. In practice, metadata is always provided.
BTC-3062