fix: return signable_payload from to_bytes for unsigned transactions#220
Merged
fix: return signable_payload from to_bytes for unsigned transactions#220
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
lcovar
force-pushed
the
BTC-3161/fix-unsigned-extrinsic-format
branch
from
793b938 to
84ffe49
Compare
Make to_bytes() for unsigned DOT transactions return signable_payload() instead of a standard V4 extrinsic. The signing payload format (call_data | era | nonce | tip | extensions | additional_signed) matches what legacy BitGoJS produces via construct.signingPayload(), preserving nonce readback in bgms. Key changes: - Transaction::new() constructor for builder-created transactions (no raw extrinsic bytes stored) - to_bytes() unsigned path calls signable_payload() instead of returning raw_bytes - parse_extrinsic() detects signing payload format (no compact length prefix or version byte) and parses call_data using metadata type registry, then extracts era/nonce/tip from signed extensions - Removed build_unsigned_extrinsic() from builder (no longer needed) BTC-3161
lcovar
force-pushed
the
BTC-3161/fix-unsigned-extrinsic-format
branch
from
84ffe49 to
9872edf
Compare
davidkaplanbitgo
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make to_bytes() for unsigned DOT transactions return signable_payload() instead of a standard V4 extrinsic. The signing payload format (call_data | era | nonce | tip | extensions | additional_signed) matches what legacy BitGoJS produces via construct.signingPayload(), preserving nonce readback in bgms.
Key changes:
BTC-3161