feat(root):add minimum length for xprv key and v2x token WP-8145#8261
Draft
rishikeshdadam136 wants to merge 1 commit intomasterfrom
Draft
feat(root):add minimum length for xprv key and v2x token WP-8145#8261rishikeshdadam136 wants to merge 1 commit intomasterfrom
rishikeshdadam136 wants to merge 1 commit intomasterfrom
Conversation
rishikeshdadam136
force-pushed
the
WP-8145
branch
from
ecce20f to
387f684
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TICKET: WP-8145
Added MIN_SENSITIVE_STRING_LENGTH = 10 inorder not to sanitize the small strings like "v2x2bc" and "xprv12sc".
Not a must needed change but good to have.