Repository navigation
Fix the fuzzing module, and check feature-gated code in CI - #8
Merged
Merged
Conversation
`fuzzing::replay_wal` and `fuzzing::open_sstable` still called the pre-seam signatures and had not compiled since the filesystem seam landed. Nobody noticed because nothing built with the feature on: `cargo clippy --all-targets` and `cargo test` both use default features, and `fuzzing` is not one. So the fix is two lines and the actual repair is the CI file. It runs clippy and the test suite with `--all-features`, because feature-gated code is precisely the code nobody compiles by accident, and a module that has not compiled in four commits is not a module anyone is fuzzing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
fuzzing::replay_walandfuzzing::open_sstablestill called the pre-seam signatures and had not compiled since #3 landed.Why nobody noticed
Nothing built with the feature on.
cargo clippy --all-targetsandcargo testboth use default features, andfuzzingis not one.The actual repair
The two-line fix is not the interesting part. This adds a CI workflow — the repository had none — that runs
fmt,clippy --all-targets --all-features -D warnings, andcargo test --all-features.--all-featuresbecause feature-gated code is precisely the code nobody compiles by accident, and a module that has not compiled in four commits is not a module anyone is fuzzing.