Skip to content

fix(frontend): derive engine ports dynamically from instance state and endpoints #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BerryUIKI merged 1 commit into from
Oct 4, 2026
Merged

fix(frontend): derive engine ports dynamically from instance state and endpoints #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 39 additions & 31 deletions frontend/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@
console.error('Failed to close app window:', err);
try {
window.close();
} catch {}

Check warning on line 186 in frontend/src/App.tsx

View workflow job for this annotation

GitHub Actions / Frontend Build & Typecheck 

Empty block statement
}
};

Expand Down Expand Up @@ -338,37 +338,45 @@
<ModelHubView />
</ErrorBoundary>
),
comfyui: (
<ErrorBoundary fallbackTitle="ComfyUI View Error">
<EmbeddedEngineView
engineType="comfyui"
title="ComfyUI"
port={comfyStatus?.port || 8188}
isRunning={Boolean(runtimeStatus?.running || comfyStatus?.online)}
isInstalled={Boolean(
instances.find((i) => i.id === 'comfyui-managed')?.status !== 'not_installed' &&
runtimeStatus?.installed !== false
)}
onStartEngine={toggleRuntime}
onDeployEngine={() => handleStartDeployment('comfyui')}
onOpenDirectory={() => setShowManagerModal(true)}
/>
</ErrorBoundary>
),
webui: (
<ErrorBoundary fallbackTitle="SD WebUI View Error">
<EmbeddedEngineView
engineType="webui"
title="SD WebUI"
port={7860}
isRunning={Boolean(instances.find((i) => i.id === 'webui-managed')?.status === 'running')}
isInstalled={Boolean(instances.find((i) => i.id === 'webui-managed')?.status !== 'not_installed')}
onStartEngine={toggleRuntime}
onDeployEngine={() => handleStartDeployment('webui')}
onOpenDirectory={() => setShowManagerModal(true)}
/>
</ErrorBoundary>
),
comfyui: (() => {
const comfyInst = instances.find((i) => i.id === 'comfyui-managed' || i.type === 'comfyui');
const dynamicPort = comfyStatus?.port || (comfyInst?.endpoint ? Number(new URL(comfyInst.endpoint).port) : 8188) || 8188;
return (
<ErrorBoundary fallbackTitle="ComfyUI View Error">
<EmbeddedEngineView
engineType="comfyui"
title="ComfyUI"
port={dynamicPort}
isRunning={Boolean(runtimeStatus?.running || comfyStatus?.online)}
isInstalled={Boolean(
instances.find((i) => i.id === 'comfyui-managed')?.status !== 'not_installed' &&
runtimeStatus?.installed !== false
)}
onStartEngine={toggleRuntime}
onDeployEngine={() => handleStartDeployment('comfyui')}
onOpenDirectory={() => setShowManagerModal(true)}
/>
</ErrorBoundary>
);
})(),
webui: (() => {
const webuiInst = instances.find((i) => i.id === 'webui-managed' || i.type === 'webui');
const dynamicPort = (webuiInst?.endpoint ? Number(new URL(webuiInst.endpoint).port) : 7860) || 7860;
return (
<ErrorBoundary fallbackTitle="SD WebUI View Error">
<EmbeddedEngineView
engineType="webui"
title="SD WebUI"
port={dynamicPort}
isRunning={Boolean(instances.find((i) => i.id === 'webui-managed')?.status === 'running')}
isInstalled={Boolean(instances.find((i) => i.id === 'webui-managed')?.status !== 'not_installed')}
onStartEngine={toggleRuntime}
onDeployEngine={() => handleStartDeployment('webui')}
onOpenDirectory={() => setShowManagerModal(true)}
/>
</ErrorBoundary>
);
})(),
settings: (
<SettingsView
onOpenCloudSettings={() => setShowCloudModal(true)}
Expand Down
Loading