Repository navigation
fix(workflow): resume durable subscriptions without duplicate inference - #174
Merged
Merged
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workflow submission is now idempotent and independent of its WebSocket subscribers. The backend persists the immutable request, node inputs/outcomes, provider job IDs and sequenced events. A reconnect only subscribes to the existing run after the last observed sequence. Disconnect does not cancel execution or submit a second inference request. Reusing a run ID with different content returns a conflict.
The canvas submits once over REST, resumes subscriptions and rejects obsolete/duplicate events. The unsupported application PING heartbeat is removed. Shutdown/restart records interrupted or uncertain work without paid resubmission. Existing raw graph WebSocket submissions remain compatible and idempotent when they supply a run ID.
Validation: 311 backend tests and 99 frontend tests passed; typecheck/lint passed (two pre-existing lint warnings). A real TestClient socket disconnect with a counted controllable runner asserts exactly one inference, resumed output, durable history and conflict rejection. Database reopen verifies replay; frontend tests assert cursor resume and stale-event isolation.
Fixes #116. Completes workflow durability for #120 alongside #172. Real remote-provider recovery remains unverified; unknown outcomes are never automatically retried.