Repository navigation
feat(frontend): implement engine connection routing integration for Issue #127 - #161
Merged
Merged
Conversation
…ssue #127 - Add connection_id field to CreativeActionRequest and GenerationProvenance types - Update creative store to support stable connection IDs with legacy engine_id fallback - Implement connection ID mapping in setEngineId (managed_comfyui -> comfyui-managed) - Update engine store to include connection_id in instances and enforce ownership - Modify lifecycle controls to route by engine type and prevent external engine control - Update CreationDock UI to use connection_id in engine selection dropdown - Add comprehensive test suite with 13 tests covering mapping, routing, and compatibility - Maintain backward compatibility by including both connection_id and engine_id in requests Tests: - Backend: 9/9 connection routing tests passed - Frontend: 13/13 connection routing tests passed Related: #127
BerryUIKI
enabled auto-merge (squash)
October 6, 2026 21:18
- Remove unused engineId and setEngineId from CreationDock destructuring - Add missing connection_id to test provenance object in creativeStore.test.ts - Replace global.fetch with globalThis.fetch for TypeScript compatibility in tests
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements comprehensive frontend integration for engine connection routing to support stable connection identifiers and proper request routing.
Changes
connection_idfield toCreativeActionRequestandGenerationProvenancewith legacyengine_idfallbackmanaged_comfyui→comfyui-managedmanaged_webui→webui-managedTest Results
Backward Compatibility
connection_idandengine_idincluded in requestsCloses #127