Repository navigation
fix(webui): correct launch flags and add Python version compatibility check (fixes #108) - #157
Merged
Merged
Conversation
… check (fixes #108) - Fix --listen flag: use boolean --listen with separate --server-name 127.0.0.1 - Remove --nowebui flag to enable native WebUI access alongside API - Add Python version compatibility check warning for non-3.10.x versions - Preserve --api flag and model directory flags (--ckpt-dir, --lora-dir, --vae-dir) - Log warning when isolated runtime Python version differs from WebUI's expected 3.10.x - Tests verify correct flag usage and version compatibility checks Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct WebUI launch flags to use proper boolean --listen and separate --server-name flags, remove --nowebui to enable native UI access, and add Python version compatibility checks.
Changes
--listenwith separate--server-name 127.0.0.1instead of--listen 127.0.0.1--nowebuiflag to allow both API and native WebUI access--apiflag for REST API access--ckpt-dir,--lora-dir,--vae-dirflags for model discoveryProblem Solved (Issue #108)
Before:
--listen 127.0.0.1incorrectly treated 127.0.0.1 as a boolean flag value--nowebuidisabled the native WebUI interfaceAfter:
--listen(boolean) +--server-name 127.0.0.1Acceptance Criteria (Issue #108)
Testing
All tests in
backend/tests/test_webui_launch_flags.pyverify:--listenfollowed by--server-name 127.0.0.1--nowebuiflag is NOT present--apiflag is preserved for API accessRelated Issues
Fixes #108
🤖 Generated with Claude Code