Timers and Delegates#1
Open
norab7 wants to merge 4 commits into
Open
Conversation
norab7
commented
Jan 23, 2024
norab7
commented
- Timers & Delays
- Blueprint Dispatchers
- Basic Actions
- Improved End Logic flow
- ActionUID
- Timers & Delays - Blueprint Dispatchers - Basic Actions - Improved Logic flow - ActionUID - JustAction actor
BenVlodgi
requested changes
Jan 23, 2024
| } | ||
| } | ||
|
|
||
| void USimpleAction::StartAction_Bound(AActor* NewActionActor, AActor* NewInstigator, FOnActionStartedDelegate Started, FOnActionInterruptedDelegate Interrupted, FOnActionEndedDelegate Ended, FOnActionCompleteDelegate Complete, FOnActionFailedDelegate Failed) { |
Owner
There was a problem hiding this comment.
I'm iffy about this pattern being in here.
Author
There was a problem hiding this comment.
If you can figure out another method I'm all ears.
Owner
|
Can you show the difference between how the properties for an action show up if their categories are collapsed or not? |
BenVlodgi
reviewed
Jan 23, 2024
BenVlodgi
requested changes
Jan 25, 2024
BenVlodgi
left a comment
BenVlodgi
left a comment
Owner
There was a problem hiding this comment.
I'll wait for the change to finishing dispatcher to use enum/tags instead of splitting it.
I also see some egyptian brackets in there.
| return nullptr; | ||
| } | ||
|
|
||
| FString USimpleAction::GetActionUID() |
| TArray<TObjectPtr<USimpleAction>> Actions; | ||
|
|
||
| FSimpleActionList() : FSimpleActionList(TArray<USimpleAction*>()) {} | ||
| FSimpleActionList(TArray<USimpleAction*> Actions) { |
Owner
There was a problem hiding this comment.
the constructor is only called for making a new object. the new was to avoid name conflicting, might not be necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.