Skip to content

chore: Expo SDK 56 → 57 → 58 + fingerprint - #147

Merged
HugoPerard merged 22 commits into
mainfrom
cursor/expo-sdk-57-58-upgrade-fb5b
Oct 23, 2026
Merged

HugoPerard merged 22 commits into
mainfrom
cursor/expo-sdk-57-58-upgrade-fb5b

Conversation

@HugoPerard

@HugoPerard HugoPerard commented Sep 21, 2026 •

Copy link
Copy Markdown
Member

Summary

Upgrade the app from Expo SDK 56 to 58 stable (via 57) and make the UI work on tablet / landscape, with theme and Reanimated follow-ups.

What’s in this PR

Expo SDK 56 → 57 → 58

  • Bumps Expo 58.0.12, React Native 0.88.0, React 19.3, Reanimated, and related Expo packages (expo install --fix).
  • Adds expo-dev-client as the recommended day-to-day workflow (Expo Go stays as a quickstart only).
  • Switches OTA runtimeVersion from appVersion to { policy: 'fingerprint' } (balanced preset). New native binaries are required when the fingerprint changes.
  • CI / EAS workflows use pnpm; README documents pnpm dev:client and local/EAS development builds.
  • SDK bumps are in separate commits (57, then 58) so an intermediate rollback is possible.

Note: Expo Go for SDK 58 may still be rolling out on the App Store / Play Store; use a development client for day-to-day work.

Theme and dark mode

  • Wires Expo Router ThemeProvider to Uniwind via useThemedStyle, so navigation chrome matches light/dark.
  • Fixes dark-mode flashes/gaps (root background, status bar, switchers, cards, inputs).
  • Adds a themed List primitive used on account and similar screens.

Responsive layouts

  • Adds src/lib/responsive.ts (Uniwind breakpoints + useResponsiveValue / useBreakpoint).
  • Adapts onboarding, auth, home, books, book detail, and account for wider viewports (tablet / landscape).
  • Layout helpers: ViewSafeScrollContent and updates to safe-area wrappers; tab content layout is simplified.

Follow-up UI fixes

  • Mascot positioning on app onboarding.
  • Animated step indicator types compatible with Reanimated 4.

Test plan

  • pnpm install && pnpm lint
  • Rebuild the development client after the SDK bump (Expo Go will not cover Better Auth / secure store).
  • Smoke: sign-in, onboarding, home, books, account — light and dark.
  • Rotate / tablet (or large simulator): layouts should use the wider breakpoints without overflowing.
  • OTA: confirm a new binary is required when the fingerprint changes.
Open in Web Open in Cursor 

cursoragent and others added 2 commits September 21, 2026 10:33
- Pin SDK 57 packages (expo@57.0.24, RN 0.86.3, reanimated 4.5.1)
- Add expo-status-bar plugin (SDK 57 requirement)
- Add @expo/dom-webview@57.0.1; update pnpm overrides for SDK 57
- Keep runtimeVersion policy appVersion (fingerprint in next commit)

Co-authored-by: prdHugo <HugoPerard@users.noreply.github.com>
- Pin SDK 58 preview packages (expo@58.0.0-preview.3, RN 0.88.0-rc.0)
- runtimeVersion: { policy: 'fingerprint' } (balanced preset default)
- Update pnpm overrides/trustPolicyExclude for SDK 58
- Fix RN strict TypeScript API breaks (refs, expo-router Stack, ViewToken)
- README: SDK 58 beta + OTA fingerprint note

Co-authored-by: prdHugo <HugoPerard@users.noreply.github.com>
@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

🚀 Expo preview is ready!

  • Project → start-ui-native-v9iizxkbojzedvpfkfzcq
  • Platforms → android, ios
  • Scheme → start-ui-native
Android
(6ee39678e141dd5902ff0eb18bcda0ff349473b6)
More info
iOS
(c2ef455ae413197060d9b4fcd74fc85a95816e9c)
More info

Learn more about 𝝠 Expo Github Action

HugoPerard and others added 13 commits September 21, 2026 15:04
Co-authored-by: Cursor <cursoragent@cursor.com>
Align expo@next peer set via expo install --fix: RN 0.88.0-rc.3,
react 19.3, refreshed expo-* / @expo/* pins. Drop preview trust exclude.

Co-authored-by: prdHugo <HugoPerard@users.noreply.github.com>
Align expo-* peers via expo install --fix. Add 2g to minimumReleaseAgeExclude
for @expo/metro-config. README: SDK 58 stable wording.

Co-authored-by: prdHugo <HugoPerard@users.noreply.github.com>
@cursor cursor Bot changed the title chore: Expo SDK 56 → 57 → 58 beta + fingerprint chore: Expo SDK 56 → 57 → 58 + fingerprint Oct 16, 2026
@HugoPerard
HugoPerard marked this pull request as ready for review October 16, 2026 08:26
cursoragent and others added 6 commits October 16, 2026 08:27
Co-authored-by: prdHugo <HugoPerard@users.noreply.github.com>
- Clarify 2g chain (Expo CLI/metro logging, kitten/philpl, SLSA)
- Pin ios/android image sdk-58 on development, staging, production

Co-authored-by: prdHugo <HugoPerard@users.noreply.github.com>
- Note Expo Go SDK 58 store rollout; prefer dev client meanwhile
- TypeScript CI: node lts/*; engines.node >=22.13; setup-node@v5
- HapticTab: Pressable + BottomTabBarButtonProps (no react-navigation fork)

Co-authored-by: prdHugo <HugoPerard@users.noreply.github.com>
- expo-router/native-tabs (SDK 58 stable)
- expo install expo@latest --fix (expo-router 58.0.24, etc.)
- minimumReleaseAgeExclude: noxcturnal stack for @expo/metro-config@58.0.15

Co-authored-by: prdHugo <HugoPerard@users.noreply.github.com>

@HugoPerard HugoPerard left a comment •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review (excluding pnpm-lock.yaml). CI is green, and the SDK upgrade is clean and well split into commits. The points below are mostly about the new layouts. I found them by reading the code and haven't tested them on a device.

To fix: scrolling blocked in ViewSafeScrollContent, sign-out icon invisible in dark mode, version overlapping content on Account, nonexistent text-md.

Minor: extra bottom padding on AuthHeader, a few fragile spots in List, flex-1 with no effect in the bottom sheets (worth checking on a device), class reordering in avatar/badge/pin-input that adds noise to the diff.

👍 Fingerprint runtimeVersion, ThemeProvider wired to Uniwind, simple responsive.ts, onboarding background computed instead of hardcoded magic values.

Comment thread src/layout/view-safe-scroll-content.tsx Resolved
Comment thread src/features/account/view-account.tsx Resolved
Comment thread src/features/account/view-account.tsx Resolved
Comment thread src/components/ui/button.tsx Resolved
Comment thread src/features/auth/auth-header.tsx Resolved
Comment thread src/components/ui/list.tsx Resolved
Comment thread pnpm-workspace.yaml Resolved
Co-authored-by: prdHugo <HugoPerard@users.noreply.github.com>
@HugoPerard

HugoPerard commented Oct 23, 2026 •

Copy link
Copy Markdown
Member Author

Re: your review from 10/23 — the must-fix items are addressed in ddc6550 (English replies on each inline thread).

Minor (not in threads):

  • flex-1 in bottom sheets: no change in ddc6550 — layout relies on RNHostView + matchContents; remaining flex-1 on buttons is cosmetic. Worth validating on device if needed.
  • Class reordering in avatar/badge/pin-input: no change — diff noise without functional impact; avoiding a commit just to reorder.

👍 Still agree on fingerprint, ThemeProvider, responsive, and onboarding.


Note: The first agent replies on inline threads were posted in French; the GitHub integration cannot edit or delete pull request review comments (403). English follow-ups were added under each of those replies. Feel free to delete the French copies if you want a single reply per thread.

@HugoPerard
HugoPerard merged commit 925c58c into main Oct 23, 2026
3 checks passed
@HugoPerard
HugoPerard deleted the cursor/expo-sdk-57-58-upgrade-fb5b branch October 23, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants