Repository navigation
chore: Expo SDK 56 → 57 → 58 + fingerprint - #147
Conversation
- Pin SDK 57 packages (expo@57.0.24, RN 0.86.3, reanimated 4.5.1) - Add expo-status-bar plugin (SDK 57 requirement) - Add @expo/dom-webview@57.0.1; update pnpm overrides for SDK 57 - Keep runtimeVersion policy appVersion (fingerprint in next commit) Co-authored-by: prdHugo <HugoPerard@users.noreply.github.com>
- Pin SDK 58 preview packages (expo@58.0.0-preview.3, RN 0.88.0-rc.0)
- runtimeVersion: { policy: 'fingerprint' } (balanced preset default)
- Update pnpm overrides/trustPolicyExclude for SDK 58
- Fix RN strict TypeScript API breaks (refs, expo-router Stack, ViewToken)
- README: SDK 58 beta + OTA fingerprint note
Co-authored-by: prdHugo <HugoPerard@users.noreply.github.com>
|
🚀 Expo preview is ready!
|
Co-authored-by: Cursor <cursoragent@cursor.com>
Align expo@next peer set via expo install --fix: RN 0.88.0-rc.3, react 19.3, refreshed expo-* / @expo/* pins. Drop preview trust exclude. Co-authored-by: prdHugo <HugoPerard@users.noreply.github.com>
Align expo-* peers via expo install --fix. Add 2g to minimumReleaseAgeExclude for @expo/metro-config. README: SDK 58 stable wording. Co-authored-by: prdHugo <HugoPerard@users.noreply.github.com>
Co-authored-by: prdHugo <HugoPerard@users.noreply.github.com>
- Clarify 2g chain (Expo CLI/metro logging, kitten/philpl, SLSA) - Pin ios/android image sdk-58 on development, staging, production Co-authored-by: prdHugo <HugoPerard@users.noreply.github.com>
- Note Expo Go SDK 58 store rollout; prefer dev client meanwhile - TypeScript CI: node lts/*; engines.node >=22.13; setup-node@v5 - HapticTab: Pressable + BottomTabBarButtonProps (no react-navigation fork) Co-authored-by: prdHugo <HugoPerard@users.noreply.github.com>
- expo-router/native-tabs (SDK 58 stable) - expo install expo@latest --fix (expo-router 58.0.24, etc.) - minimumReleaseAgeExclude: noxcturnal stack for @expo/metro-config@58.0.15 Co-authored-by: prdHugo <HugoPerard@users.noreply.github.com>
There was a problem hiding this comment.
Review (excluding pnpm-lock.yaml). CI is green, and the SDK upgrade is clean and well split into commits. The points below are mostly about the new layouts. I found them by reading the code and haven't tested them on a device.
To fix: scrolling blocked in ViewSafeScrollContent, sign-out icon invisible in dark mode, version overlapping content on Account, nonexistent text-md.
Minor: extra bottom padding on AuthHeader, a few fragile spots in List, flex-1 with no effect in the bottom sheets (worth checking on a device), class reordering in avatar/badge/pin-input that adds noise to the diff.
👍 Fingerprint runtimeVersion, ThemeProvider wired to Uniwind, simple responsive.ts, onboarding background computed instead of hardcoded magic values.
Co-authored-by: prdHugo <HugoPerard@users.noreply.github.com>
|
Re: your review from 10/23 — the must-fix items are addressed in Minor (not in threads):
👍 Still agree on fingerprint, ThemeProvider, responsive, and onboarding. Note: The first agent replies on inline threads were posted in French; the GitHub integration cannot edit or delete pull request review comments (403). English follow-ups were added under each of those replies. Feel free to delete the French copies if you want a single reply per thread. |
Summary
Upgrade the app from Expo SDK 56 to 58 stable (via 57) and make the UI work on tablet / landscape, with theme and Reanimated follow-ups.
What’s in this PR
Expo SDK 56 → 57 → 58
expo install --fix).expo-dev-clientas the recommended day-to-day workflow (Expo Go stays as a quickstart only).runtimeVersionfromappVersionto{ policy: 'fingerprint' }(balanced preset). New native binaries are required when the fingerprint changes.pnpm dev:clientand local/EAS development builds.Note: Expo Go for SDK 58 may still be rolling out on the App Store / Play Store; use a development client for day-to-day work.
Theme and dark mode
ThemeProviderto Uniwind viauseThemedStyle, so navigation chrome matches light/dark.Listprimitive used on account and similar screens.Responsive layouts
src/lib/responsive.ts(Uniwind breakpoints +useResponsiveValue/useBreakpoint).ViewSafeScrollContentand updates to safe-area wrappers; tab content layout is simplified.Follow-up UI fixes
Test plan
pnpm install && pnpm lint