m12-pr19: TD-1 first cut - extract _module_state.py from routes/generate/jobs.py

[BalaShankar9]

m12-pr19: TD-1 first cut — extract module-state helpers from routes/generate/jobs.py

The routes/generate/jobs.py module had grown to 2496 LOC. This PR is
the first cut of TD-1 (split jobs.py): extract the cohesive group of
pure module-state / preferred-lock helpers into a sibling module
_module_state.py (195 LOC) and re-import them in jobs.py so all
existing import paths and mock.patch("app.api.routes.generate.jobs._foo")
call sites continue to resolve unchanged.

Result

• backend/app/api/routes/generate/jobs.py: 2496 → 2358 LOC
• backend/app/api/routes/generate/_module_state.py: new, 195 LOC

Extracted (12 names + 1 re-export of _bootstrap_registry)

• _track_bootstrap, _get_model_health_summary
• _DEFAULT_REQUESTED_MODULES, _SNAKE_TO_CAMEL, _CAMEL_TO_SNAKE, _IDENTITY_KEYS
• _now_ms, _apply_preferred_lock
• _default_module_states, _merge_module_states
• _normalize_requested_modules, _module_has_content

Why this cut first

• These are pure functions / module-level constants with no DB
  dependency. The only side-effecting helper (_track_bootstrap) is a
  thin shim over bootstrap_registry which moves with it.
• The rest of jobs.py (persistence helpers, runtime executor, route
  handlers) is more entangled with DB clients, Temporal handles, and
  SSE streaming — those should follow in subsequent PRs after a deeper
  survey, not in a single 2500-line megamove.

Validation

• pytest tests/test_generate_jobs_smoke.py tests/test_task_registry.py
  tests/temporal/ -x → 109 passed in 2.94s
• All mock.patch("app.api.routes.generate.jobs._foo") paths still
  resolve (verified by the smoke test suite which patches several of
  these names).
• _BOOTSTRAP_TASKS still aliases the same set object that the
  bootstrap_registry uses internally (confirmed in module re-export
  block).

Stacked on PR #36 (m12-pr18). Base branch: m12-pr18-test-temporal-resume.

Follow-ups

• m12-pr20+: extract persistence helpers (persist, ensure, sync*)
• m12-pr21+: extract runtime executor (run_generation_job*)
• Final TD-1 close-out: route handlers remain in jobs.py

[Copilot]

Pull request overview

This PR is the first TD-1 split of the large backend/app/api/routes/generate/jobs.py, extracting “module-state / preferred-lock” pure helpers into a new sibling module while preserving the legacy app.api.routes.generate.jobs._foo import paths via re-imports.

Changes:

• Added backend/app/api/routes/generate/_module_state.py containing module-state constants/helpers and the bootstrap task shim.
• Removed the extracted helper implementations from jobs.py and re-imported them from ._module_state to keep existing imports / mock.patch() targets stable.
• Updated context/CHANGELOG_INTELLIGENCE.md to record m12-pr19 in the PR ledger.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
context/CHANGELOG_INTELLIGENCE.md	Adds a ledger entry for m12-pr19 and updates m12-pr18’s PR reference.
backend/app/api/routes/generate/jobs.py	Removes inlined helper implementations and re-imports them from ._module_state to reduce file size while preserving legacy symbol paths.
backend/app/api/routes/generate/_module_state.py	New module containing the extracted “pure” helpers/constants and bootstrap shim.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.