m12-pr06: P1-11 baseline test triage — 7 stale tests fixed, 4090/4090 green

[BalaShankar9]

P1-11 baseline test triage — 7 failures fixed, 4090/4090 green

Triaged the entire backend/tests + ai_engine/tests baseline. All 7 failing
tests were stale: they pointed at code that has since moved or been renamed.
No production bugs were uncovered — every fix is in test code only.

Failures and fixes

#	Test	Root cause	Fix
1	test_aim_pipeline_events::test_generate_section_emits_writer_reviewer_pair_per_attempt_and_complete_on_pass	Counted all events tagged agent=reviewer; pipeline emits 2 lifecycle (agent_status) + 1 attempt event tagged with the same agent	Filter to event_type == "agent_status" (matches sibling tests' convention)
2	test_observability_w3::test_metrics_endpoint_exposes_llm_and_cost_gauges	Greps backend/main.py; metrics moved	Inspect backend.app.core.prometheus_collectors
3	test_perf_optimizations::test_metrics_endpoint_exposes_cache_and_phase_gauges	Same as #2	Same as #2
4	test_quality_scorer::test_metrics_endpoint_exposes_doc_quality_gauges	Same as #2	Same as #2
5	test_prod_readiness_audit::test_gemini_provider_invokes_circuit_breaker	Inspected outer wrapper; breaker lives in _inner	Inspect _generate_content_throttled_inner
6	test_prod_readiness_audit::test_webhook_idempotency_migration_exists	Path database/migrations/20260420_*.sql; actual file is supabase/migrations/20260420000000_*.sql	Updated path
7	test_tenancy_isolation::test_unauthenticated_resource_routes_return_401	/api/missions/{id} was removed → returns 404 not 401	Switched probe to stable /api/jobs/{job_id}

Verification

$ python -m pytest backend/tests ai_engine/tests --no-cov -q --tb=no
4090 passed, 26 skipped, 22 warnings in 259.79s (0:04:19)

Blueprint

Section 18: P1-11 NEEDS-TRIAGE → SHIPPED (m12-pr06) — 7 stale tests pointing at moved/renamed code; 4090/4090 green.

Net diff

7 files, +26 / -10. Test code only + 1 blueprint line.

Stack

Stacked on m12-pr05 (#23). Burns down item #2 in the m12 ranked plan.
Next up: m12-pr07 (P1-8 cost attribution).

[Copilot]

Pull request overview

Updates stale test anchors after recent code moves/renames and records the triage as shipped in the architecture blueprint, bringing the baseline back to fully green.

Changes:

• Fix AIM pipeline event test to count only lifecycle (agent_status) events for writer/reviewer.
• Update metrics “source greps” to inspect backend/app/core/prometheus_collectors.py instead of backend/main.py, and adjust a circuit-breaker source anchor to target the real Gemini chokepoint.
• Update test paths/probes to reflect repo layout and API route removals (Supabase migrations path; swap removed /api/missions/{id} to /api/jobs/{id}).

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
docs/architecture/WORLD_CLASS_ARCHITECTURE_BLUEPRINT.md	Marks P1-11 as SHIPPED with the final baseline status.
backend/tests/unit/test_quality_scorer.py	Points metrics marker assertions at prometheus_collectors source.
backend/tests/unit/test_prod_readiness_audit.py	Anchors breaker check to _generate_content_throttled_inner; updates migration path.
backend/tests/unit/test_perf_optimizations.py	Points metrics marker assertions at prometheus_collectors source.
backend/tests/unit/test_observability_w3.py	Points metrics marker assertions at prometheus_collectors source.
backend/tests/security/test_tenancy_isolation.py	Switches unauthenticated probe to stable /api/jobs/{job_id} route.
backend/tests/aim/test_aim_pipeline_events.py	Filters event counts to agent_status to avoid counting attempt events.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.