Add GSA10 exception to UnitType - #353
Open
johannaisak wants to merge 3 commits into
Open
Conversation
Assigns correct unit types for GSA10
johannaisak
added
status:do-not-merge
Contributor
Author
|
@BHoMBot check installer |
|
@johannaisak to confirm, the following actions are now queued:
|
Contributor
Author
|
@BHoMBot check installer |
|
@johannaisak to confirm, the following actions are now queued:
|
Contributor
Author
|
@BHoMBot check installer |
johannaisak
requested review from
RubenKoopman
and removed request for
MaxwellGarnett
July 27, 2026 09:57
RubenKoopman
approved these changes
Jul 27, 2026
RubenKoopman
left a comment
RubenKoopman
left a comment
There was a problem hiding this comment.
The GSA output for the bar force, displacement, stress and strain has been compared to the results pulled in Grasshopper. The units are correctly pulled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assigns correct unit types for GSA10.2
NOTE: Depends on
Issues addressed by this PR
Closes #352
Test files
https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/GSA_Toolkit/%23353-Unit-conversion-in-GSA10?csf=1&web=1&e=QO6JQA
Changelog
Additional comments