chore(a11y): enhance accessibility by adding aria-labels and titles to interactive elements#343
Open
OTobi21 wants to merge 13 commits into
Open
chore(a11y): enhance accessibility by adding aria-labels and titles to interactive elements#343OTobi21 wants to merge 13 commits into
OTobi21 wants to merge 13 commits into
Conversation
Contributor
|
@OTobi21 please resolve conflicts |
Contributor
Author
|
conflicts have been resolved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #217
Add explicit accessible names to icon-only interactive elements and surface guidance for enabling jsx-a11y. Specifically:
aria-label/titleto icon-only<button>and links across components (Navbar, dropdowns, modals, banners, etc.).aria-hiddenin Icon.tsx.eslint-plugin-jsx-a11y(note: plugin not force-enabled here due to an ESLint flat-config compatibility issue).Type of Change
Testing Strategy
Manual spot checks of affected UI (open/close modals, nav actions, copy/address buttons) to confirm labels and tooltips surface correctly.
Accessibility smoke tests with Lighthouse / axe recommended (run locally or in CI).
Recommended dev commands:
npm run dev— manual UI checksnpm run test— run unit tests (if present)npm run lint— run linter after enabling jsx-a11y per docsI have run the linter and type checker
I have added/updated tests
All existing tests pass
Self-Review Checklist
Notes: I attempted to enable
eslint-plugin-jsx-a11yautomatically but encountered a FlatCompat/config compatibility error; see A11Y_ESLINT.md for a safe, step-by-step enablement plan.