Add compound XDR builder endpoint#168
Open
YfengJ wants to merge 5 commits into
Open
Conversation
Contributor
|
@YfengJ please work on the CI build it failed |
Author
|
Thanks for the heads-up. I pushed a CI fix in 16ca24e. What changed:
Verified locally with:
|
…builder-155 # Conflicts: # src/app.module.ts
…into codex/compound-xdr-builder-155 # Conflicts: # src/app.module.ts
Author
|
Follow-up: upstream main moved after my CI fix, so I merged the latest main into this branch and resolved the app module conflict without dropping the transaction, orders, or gas modules. Latest head is 2511472. I re-ran the CI-equivalent local checks successfully:
|
Author
|
One more note: the latest API CI run for head 2511472 appears to be in action_required rather than failed: https://github.com/BETAIL-BOYS/TradeFlow-API/actions/runs/28102816366 It looks like it may need maintainer approval to run for the forked PR. I do not see a new code failure from this latest run yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TransactionsModulewithPOST /api/v1/transactions/buildfor building unsigned Stellar transaction envelopes.TransactionBuilderto assemble sequentialpaymentandpathPaymentStrictSendoperations into one base64 XDR response.Closes #155
Validation
npm ci --legacy-peer-deps --ignore-scripts --no-audit --no-fundnpx jest src/transactions/transactions.service.spec.ts src/transactions/transactions.controller.spec.ts --runInBand✅ 2 suites / 3 tests passednpm test -- --runInBand❌ existing unrelated failure insrc/pools/pools.controller.int.spec.tswhereres.body.statusisundefinedinstead ofsuccessnpm run build❌ existing unrelated compile failures around loggerLogLevel, missing dynamic module imports, Prisma generated members,express-rate-limit, and websocket/prisma model types; no errors were reported from the new transactions filesgit diff --check✅