Backend Indexer: Handle missed ledgers on startup#382
Open
Godfrey-Delight wants to merge 7 commits into
Open
Conversation
Added detectGap() integrated into runIndexer's startup path to detect and handle missed ledgers. On first run, defaults to ledger 1 instead of the invalid 0. Logs a warning when the gap exceeds 100 ledgers, and resets to the current ledger if the stored value is somehow ahead of the network. Also fixed a pre-existing bug where startLedger = 0 was passed to Soroban RPC on first run, and resolved TypeScript type mismatches with the v11 Stellar SDK (txHash property, event type). 23 unit/integration tests cover all gap detection edge cases, RPC/Prisma error propagation, error recovery in the event loop, and the stored-ahead-of-network reset scenario.
|
@Godfrey-Delight Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…b.com/Godfrey-Delight/bc-forge into feat/indexer-gap-detection-on-startup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added detectGap() integrated into runIndexer's startup path to detect and handle missed ledgers. On first run, defaults to ledger 1 instead of the invalid 0. Logs a warning when the gap exceeds 100 ledgers, and resets to the current ledger if the stored value is somehow ahead of the network. Also fixed a pre-existing bug where startLedger = 0 was passed to Soroban RPC on first run, and resolved TypeScript type mismatches with the v11 Stellar SDK (txHash property, event type). 23 unit/integration tests cover all gap detection edge cases, RPC/Prisma error propagation, error recovery in the event loop, and the stored-ahead-of-network reset scenario.
Type of change
Checklist
pre-commit run --all-fileslocally and it passedBreaking changes?
No
Related issues
Closes #303