feat(react): implement reusable Tabs component (#234)#372
Open
Hollujay wants to merge 3 commits into
Open
Conversation
- Add compound Tabs component with Tabs.List, Tabs.Tab, Tabs.Panel - Support underline, pills, and tabs variants plus sm/md/lg sizes - Include full WAI-ARIA keyboard navigation (ArrowLeft/Right, Home, End) - Support controlled and uncontrolled modes - Add 27 unit tests covering rendering, a11y, keyboard nav, props - Add MDX documentation with props table and usage examples
|
@Hollujay Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements a reusable, accessible Tabs compound component for
@bc-forge/reactper issue #234.Deliverables
react/src/components/Tabs.tsxreact/src/components/Tabs.test.tsxreact/src/components/Tabs.stories.mdxreact/src/components/index.tsComponent API
Props
variant'underline' | 'pills' | 'tabs''underline'size'sm' | 'md' | 'lg''md'valuestringdefaultValuestring''onChange(value: string) => voidAll subcomponents (
List,Tab,Panel) accept standard HTML attributes via...rest.Accessibility
role="tablist"/role="tab"/role="tabpanel"per WAI-ARIA tabs patternaria-selected,aria-controls,aria-labelledbywired between tabs and panelstabIndex(only active tab reachable via keyboard)Testing
Notes
Alertcomponent conventions (forwardRef, named function expressions, inline styles, explicit type exports)Closes #234