Fix errors in update-spring-dependencies.yml#51
Merged
rujche merged 5 commits intoJun 15, 2026
Conversation
Return Optional from getCurrentVersion instead of calling Optional.get() on a possibly-empty stream, and guard the update logic with availability flags so an absent prerelease version no longer crashes the runner.
…rkflow Close old superseded PRs before creating the new one, and comment /azp run only on the newly created PR.
rujche
changed the title
update-spring-dependencies.yml
Netyyyy
reviewed
Jun 15, 2026
| git commit -m "Upgrade external dependencies to align with Spring Boot ${{ env.spring_boot_version }}" | ||
| git push "https://${{ secrets.USER }}:${{ secrets.ACCESS_TOKEN }}@github.com/${{ secrets.USER }}/azure-sdk-for-java.git" "HEAD:${{ env.update_branch }}" | ||
| - name: Close Old Pull Requests | ||
| if: ${{ env.need_update_version == 'true' }} |
Member
There was a problem hiding this comment.
it will close the working PR: Azure/azure-sdk-for-java#49501
Member
Author
There was a problem hiding this comment.
Not it will skip other steps if there is any PR with specific title prefix. Here are test pipelines:
Netyyyy
reviewed
Jun 15, 2026
| owner: 'Azure', | ||
| repo: 'azure-sdk-for-java', | ||
| issue_number: prNumber, | ||
| body: comment1 |
Member
There was a problem hiding this comment.
comment not works: Azure/azure-sdk-for-java#49502 (comment)
Member
Author
There was a problem hiding this comment.
As the comment said, it's caused by adding new commits after adding this comment, it's not caused by the error of current file, we can ignore it.
Add a dedicated check job that detects open PRs titled 'External dependencies upgrade - Spring Boot' and gates the update job via needs/if. Reuse the PR title prefix via env and rename jobs to reflect their purpose.
The check job already skips the pipeline when a matching open PR exists, so no old PR can remain when this step would run.
rujche
deleted the
rujche/main/fix-error-in-update-spring-dependencies.yml
branch
github-project-automation
Bot
moved this from In Progress
to Done
in Spring Cloud Azure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Pipelines