Skip to content

fix: pin 27 unpinned action(s),extract 2 unsafe expression(s) to env vars #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dagecko wants to merge 1 commit into
base: master
Choose a base branch
from
+33 −29
Open

fix: pin 27 unpinned action(s),extract 2 unsafe expression(s) to env vars #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/azure-login-canary.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,15 @@ jobs:
uses: actions/checkout@v6

- name: 'Az CLI login with subscription'
uses: azure/login@v1
uses: azure/login@cb79c773a3cfa27f31f25eb3f677781210c9ce3d # v1
with:
creds: ${{ secrets.AZURE_CREDENTIALS }}

- run: |
az account show --output none

- name: 'Az CLI login without subscription'
uses: azure/login@v1
uses: azure/login@cb79c773a3cfa27f31f25eb3f677781210c9ce3d # v1
with:
creds: ${{ secrets.AZURE_CREDENTIALS }}
allow-no-subscriptions: true
Expand All @@ -50,7 +50,7 @@ jobs:
az account show --output none

- name: 'Az CLI login with subscription OIDC'
uses: azure/login@v1
uses: azure/login@cb79c773a3cfa27f31f25eb3f677781210c9ce3d # v1
with:
client-id: ${{ secrets.AZURE_CLIENTID }}
tenant-id: ${{ secrets.AZURE_TENANTID }}
Expand All @@ -60,7 +60,7 @@ jobs:
az account show --output none

- name: 'Az CLI login without subscription OIDC'
uses: azure/login@v1
uses: azure/login@cb79c773a3cfa27f31f25eb3f677781210c9ce3d # v1
with:
client-id: ${{ secrets.AZURE_CLIENTID }}
tenant-id: ${{ secrets.AZURE_TENANTID }}
Expand Down Expand Up @@ -88,4 +88,6 @@ jobs:
echo "report=$REPORT" >> $GITHUB_OUTPUT
- name: Post to slack
shell: bash
run: curl -X POST -H 'Content-type:application/json' --data '{"blocks":[{"type":"section","text":{"type":"mrkdwn","text":"${{steps.slack_report.outputs.report}}"}}]}' https://hooks.slack.com/services/${{SECRETS.SLACK_CHANNEL_SECRET}}
run: curl -X POST -H 'Content-type:application/json' --data '{"blocks":[{"type":"section","text":{"type":"mrkdwn","text":"${{steps.slack_report.outputs.report}}"}}]}' https://hooks.slack.com/services/${SLACK_CHANNEL_SECRET}
env:
SLACK_CHANNEL_SECRET: ${{SECRETS.SLACK_CHANNEL_SECRET}}
28 changes: 15 additions & 13 deletions .github/workflows/azure-login-integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
# continue-on-error: true
steps:
- name: 'Az CLI login with subscription'
uses: azure/login@v1
uses: azure/login@cb79c773a3cfa27f31f25eb3f677781210c9ce3d # v1
with:
creds: ${{ secrets.AZURE_CREDENTIALS }}

Expand All @@ -23,7 +23,7 @@ jobs:
az vm list --output none

- name: 'Az CLI login without subscription'
uses: azure/login@v1
uses: azure/login@cb79c773a3cfa27f31f25eb3f677781210c9ce3d # v1
with:
creds: ${{ secrets.AZURE_CREDENTIALS }}
allow-no-subscriptions: true
Expand All @@ -32,24 +32,24 @@ jobs:
az account show --output none

- name: 'Azure PowerShell login with subscription'
uses: azure/login@v1
uses: azure/login@cb79c773a3cfa27f31f25eb3f677781210c9ce3d # v1
with:
creds: ${{ secrets.AZURE_CREDENTIALS }}
enable-AzPSSession: true

- uses: azure/powershell@v3
- uses: azure/powershell@f5b8adcfff1904872c7b98d4012d4914d74b1a82 # v3
with:
inlineScript: "(Get-AzContext).Environment.Name"
azPSVersion: "latest"

- name: 'Azure PowerShell login without subscription'
uses: azure/login@v1
uses: azure/login@cb79c773a3cfa27f31f25eb3f677781210c9ce3d # v1
with:
creds: ${{secrets.AZURE_CREDENTIALS}}
enable-AzPSSession: true
allow-no-subscriptions: true

- uses: azure/powershell@v3
- uses: azure/powershell@f5b8adcfff1904872c7b98d4012d4914d74b1a82 # v3
with:
inlineScript: "(Get-AzContext).Environment.Name"
azPSVersion: "latest"
Expand All @@ -59,7 +59,7 @@ jobs:
# continue-on-error: true
steps:
- name: 'Az CLI login with subscription'
uses: azure/login@v1
uses: azure/login@cb79c773a3cfa27f31f25eb3f677781210c9ce3d # v1
with:
client-id: ${{ secrets.AZURE_CLIENTID }}
tenant-id: ${{ secrets.AZURE_TENANTID }}
Expand All @@ -70,7 +70,7 @@ jobs:
az vm list --output none

- name: 'Az CLI login without subscription'
uses: azure/login@v1
uses: azure/login@cb79c773a3cfa27f31f25eb3f677781210c9ce3d # v1
with:
client-id: ${{ secrets.AZURE_CLIENTID }}
tenant-id: ${{ secrets.AZURE_TENANTID }}
Expand All @@ -80,27 +80,27 @@ jobs:
az account show --output none

- name: 'Azure PowerShell login with subscription'
uses: azure/login@v1
uses: azure/login@cb79c773a3cfa27f31f25eb3f677781210c9ce3d # v1
with:
client-id: ${{ secrets.AZURE_CLIENTID }}
tenant-id: ${{ secrets.AZURE_TENANTID }}
subscription-id: ${{ secrets.AZURE_SUBSCRIPTIONID }}
enable-AzPSSession: true

- uses: azure/powershell@v3
- uses: azure/powershell@f5b8adcfff1904872c7b98d4012d4914d74b1a82 # v3
with:
inlineScript: "(Get-AzContext).Environment.Name"
azPSVersion: "latest"

- name: 'Azure PowerShell login without subscription'
uses: azure/login@v1
uses: azure/login@cb79c773a3cfa27f31f25eb3f677781210c9ce3d # v1
with:
client-id: ${{ secrets.AZURE_CLIENTID }}
tenant-id: ${{ secrets.AZURE_TENANTID }}
enable-AzPSSession: true
allow-no-subscriptions: true

- uses: azure/powershell@v3
- uses: azure/powershell@f5b8adcfff1904872c7b98d4012d4914d74b1a82 # v3
with:
inlineScript: "(Get-AzContext).Environment.Name"
azPSVersion: "latest"
Expand All @@ -126,4 +126,6 @@ jobs:

- name: Post to slack
shell: bash
run: curl -X POST -H 'Content-type:application/json' --data '{"blocks":[{"type":"section","text":{"type":"mrkdwn","text":"${{steps.slack_report.outputs.report}}"}}]}' https://hooks.slack.com/services/${{SECRETS.SLACK_CHANNEL_SECRET}}
run: curl -X POST -H 'Content-type:application/json' --data '{"blocks":[{"type":"section","text":{"type":"mrkdwn","text":"${{steps.slack_report.outputs.report}}"}}]}' https://hooks.slack.com/services/${SLACK_CHANNEL_SECRET}
env:
SLACK_CHANNEL_SECRET: ${{SECRETS.SLACK_CHANNEL_SECRET}}
6 changes: 3 additions & 3 deletions .github/workflows/azure-login-negative.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
- name: Run Azure PowerShell
id: ps_3
continue-on-error: true
uses: azure/powershell@v3
uses: azure/powershell@f5b8adcfff1904872c7b98d4012d4914d74b1a82 # v3
with:
azPSVersion: "latest"
inlineScript: |
Expand Down Expand Up @@ -186,7 +186,7 @@ jobs:
- name: Run Azure PowerShell
id: ps_8
continue-on-error: true
uses: azure/powershell@v3
uses: azure/powershell@f5b8adcfff1904872c7b98d4012d4914d74b1a82 # v3
with:
azPSVersion: "latest"
inlineScript: |
Expand Down Expand Up @@ -216,7 +216,7 @@ jobs:
- name: Run Azure PowerShell
id: ps_9
continue-on-error: true
uses: azure/powershell@v3
uses: azure/powershell@f5b8adcfff1904872c7b98d4012d4914d74b1a82 # v3
with:
azPSVersion: "latest"
inlineScript: |
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/azure-login-positive.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
az vm list --output none

- name: Run Azure PowerShell
uses: azure/powershell@v3
uses: azure/powershell@f5b8adcfff1904872c7b98d4012d4914d74b1a82 # v3
with:
azPSVersion: "latest"
inlineScript: |
Expand All @@ -69,7 +69,7 @@ jobs:
az account show --output none

- name: Run Azure PowerShell again
uses: azure/powershell@v3
uses: azure/powershell@f5b8adcfff1904872c7b98d4012d4914d74b1a82 # v3
with:
azPSVersion: "latest"
inlineScript: |
Expand All @@ -92,7 +92,7 @@ jobs:
az vm list --output none

- name: Run Azure PowerShell
uses: azure/powershell@v3
uses: azure/powershell@f5b8adcfff1904872c7b98d4012d4914d74b1a82 # v3
with:
azPSVersion: "latest"
inlineScript: |
Expand Down Expand Up @@ -160,7 +160,7 @@ jobs:
az vm list --output none

- name: Run Azure PowerShell
uses: azure/powershell@v3
uses: azure/powershell@f5b8adcfff1904872c7b98d4012d4914d74b1a82 # v3
with:
azPSVersion: "latest"
inlineScript: |
Expand All @@ -183,7 +183,7 @@ jobs:
az account show --output none

- name: Run Azure PowerShell again
uses: azure/powershell@v3
uses: azure/powershell@f5b8adcfff1904872c7b98d4012d4914d74b1a82 # v3
with:
azPSVersion: "latest"
inlineScript: |
Expand All @@ -209,7 +209,7 @@ jobs:
}

- name: Run Azure PowerShell
uses: azure/powershell@v3
uses: azure/powershell@f5b8adcfff1904872c7b98d4012d4914d74b1a82 # v3
with:
azPSVersion: "latest"
inlineScript: |
Expand All @@ -230,7 +230,7 @@ jobs:
az account show --output none

- name: Run Azure PowerShell
uses: azure/powershell@v3
uses: azure/powershell@f5b8adcfff1904872c7b98d4012d4914d74b1a82 # v3
with:
azPSVersion: "latest"
inlineScript: |
Expand Down Expand Up @@ -309,7 +309,7 @@ jobs:
az group list --output none

- name: Run Azure PowerShell again
uses: azure/powershell@v3
uses: azure/powershell@f5b8adcfff1904872c7b98d4012d4914d74b1a82 # v3
with:
azPSVersion: "latest"
inlineScript: |
Expand Down