Repository navigation
Rename naming skill to azure-typespec-sdk-naming - #17445
Merged
Haoling Dong (haolingdong-msft) merged 1 commit intoNov 2, 2026
Merged
Haoling Dong (haolingdong-msft) merged 1 commit into
Haoling Dong (haolingdong-msft) merged 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Haoling Dong (haolingdong-msft)
requested review from
a team,
catalinaperalta,
Helen Gao (helen229) and
Praveen Kuttappan (praveenkuttappan)
as code owners
October 30, 2026 07:17
|
Azure Pipelines: Successfully started running 1 pipeline(s). 70 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Full syncs remove the old naming skill without distributing its renamed replacement, while evaluations of pre-rename branches silently omit the required naming dependency.
1 open issue
What changed in this PR
Renames the shared TypeSpec SDK naming skill to azure-typespec-sdk-naming and updates its authoring and evaluation integrations, alongside the companion specs-repository PR. The intended scope is a rename only, with no naming-rule changes.
Changes:
- Moves the skill, reference guidance, tests, and fixtures to the new directory.
- Updates authoring guidance and evaluation prompts, paths, and invocation expectations.
- Updates evaluation discovery and benchmark pipeline references.
| File | Description |
|---|---|
evals/workflows/mock/typespec-naming-handoffs.eval.yaml |
Updates handoff skill names and fixture paths. |
eng/common/pipelines/skill-eval.yml |
Updates naming-evaluation discovery. |
.github/skills/README.md |
Updates the skill listing and link. |
.github/skills/azure-typespec-sdk-naming/SKILL.md |
Renames the skill metadata. |
.github/skills/azure-typespec-sdk-naming/references/naming-conventions.md |
Relocates shared naming guidance. |
.github/skills/azure-typespec-sdk-naming/references/csharp-naming.md |
Relocates C# member naming rules. |
.github/skills/azure-typespec-sdk-naming/references/csharp-model-naming.md |
Relocates C# model naming rules. |
.github/skills/azure-typespec-sdk-naming/references/apply.md |
Relocates customization instructions. |
.github/skills/azure-typespec-sdk-naming/evals/README.md |
Updates evaluation command paths. |
.github/skills/azure-typespec-sdk-naming/evals/preservation.test.mjs |
Relocates preservation checks. |
.github/skills/azure-typespec-sdk-naming/evals/fixtures/standalone-apply/tspconfig.yaml |
Relocates fixture configuration. |
.github/skills/azure-typespec-sdk-naming/evals/fixtures/standalone-apply/package.json |
Relocates fixture dependency metadata. |
.github/skills/azure-typespec-sdk-naming/evals/fixtures/standalone-apply/mock-typespec-compiler/tsp.mjs |
Relocates the mock compiler. |
.github/skills/azure-typespec-sdk-naming/evals/fixtures/standalone-apply/mock-typespec-compiler/package.json |
Relocates mock compiler metadata. |
.github/skills/azure-typespec-sdk-naming/evals/fixtures/standalone-apply/main.tsp |
Relocates the TypeSpec fixture. |
.github/skills/azure-typespec-sdk-naming/evals/fixtures/standalone-apply/existing-client.tsp |
Relocates existing customization fixtures. |
.github/skills/azure-typespec-sdk-naming/evals/fixtures/generic-customization-mcp.mjs |
Relocates the generic customization mock. |
.github/skills/azure-typespec-sdk-naming/evals/fixtures/customization-mcp.test.mjs |
Relocates mock-tool tests. |
.github/skills/azure-typespec-sdk-naming/evals/fixtures/customization-mcp.mjs |
Relocates naming-validation mocks. |
.github/skills/azure-typespec-sdk-naming/evals/eval.yaml |
Updates evaluation identity and skill references. |
.github/skills/azure-typespec-author/SKILL.md |
Updates naming-skill delegation. |
.github/skills/azure-typespec-author/references/validation.md |
Updates the validation guidance reference. |
.github/skills/azure-typespec-author/references/client-configuration.md |
Updates naming workflow references. |
.github/skills/azure-typespec-author/evaluate/pipeline/typespec-author-preeval.yml |
Updates branch-overlay paths. |
.github/skills/azure-typespec-author/evaluate/pipeline/typespec-author-invoke-shard.ts |
Updates naming dependency detection. |
.github/skills/azure-typespec-author/evaluate/pipeline/typespec-author-invoke-shard.test.ts |
Updates staging and overlay test names. |
.github/skills/azure-typespec-author/evaluate/evals/007012.eval.yaml |
Updates required naming invocation. |
.github/skills/azure-typespec-author/evaluate/evals/007008.eval.yaml |
Updates disallowed naming invocation. |
.github/skills/azure-typespec-author/evaluate/evals/007007.eval.yaml |
Updates disallowed naming invocation. |
.github/skills/azure-typespec-author/evaluate/evals/007006.eval.yaml |
Updates required naming invocations. |
.github/skills/azure-typespec-author/evaluate/evals/007005.eval.yaml |
Updates required naming invocations. |
.github/skills/azure-typespec-author/evaluate/evals/007004.eval.yaml |
Updates fixture paths and invocation expectations. |
.github/skills/azure-typespec-author/evaluate/evals/007003.eval.yaml |
Updates required naming invocations. |
.github/skills/azure-typespec-author/evaluate/evals/007002.eval.yaml |
Updates required naming invocations. |
.github/skills/azure-typespec-author/evaluate/evals/007001.eval.yaml |
Updates required naming invocations. |
.github/skills/azure-typespec-author/evaluate/.vally.yaml |
Updates skill mounts and cleanup paths. |
.github/skills/.vally.yaml |
Updates evaluation discovery paths. |
Review effort: Balanced
Contributor
|
The following pipelines have been queued for testing: |
JoshLove-msft
approved these changes
Oct 30, 2026
Member
Author
|
/check-enforcer override |
Renhe Li (lirenhe)
approved these changes
Nov 2, 2026
Haoling Dong (haolingdong-msft)
merged commit Nov 2, 2026
a5ebc4b
into
Azure:main
22 of 23 checks passed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename
azsdk-common-typespec-namingtoazure-typespec-sdk-naming.Move the skill directory and update its name and references in authoring guidance, evaluation configuration and fixtures, skill documentation, and evaluation pipelines. No behavior or naming-rule changes.
Companion PR: Azure/azure-rest-api-specs#47778
Validation
node --test .github\skills\azure-typespec-sdk-naming\evals\fixtures\customization-mcp.test.mjs .github\skills\azure-typespec-sdk-naming\evals\preservation.test.mjs .github\skills\azure-typespec-author\evaluate\pipeline\typespec-author-invoke-shard.test.ts- passed, 21 tests..github\skills:vally lint azure-typespec-sdk-naming --strict- passed..github\skills:vally lint -e azure-typespec-sdk-naming\evals\eval.yaml --strict- passed.