Repository navigation
Event processor - #17346
Merged
Chidozie Ononiwu (chidozieononiwu) merged 3 commits intoOct 21, 2026
Merged
Event processor#17346Chidozie Ononiwu (chidozieononiwu) merged 3 commits into
Chidozie Ononiwu (chidozieononiwu) merged 3 commits into
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 71 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The complementary job conditions preserve event coverage, with appropriate permissions and no identified blocking issues.
No open issues 🎉
What changed in this PR
Splits event processing into separate jobs so only newly opened issues incur Azure authentication and Key Vault access.
Changes:
- Adds a non-Azure job for all other events.
- Narrows job permissions to their respective needs.
- Removes commented-out build-from-source instructions.
| File | Description |
|---|---|
.github/workflows/event-processor.yml |
Separates Azure-dependent processing from other events and reduces permissions. |
Review effort: Balanced
Alan Zimmer (alzimmermsft)
approved these changes
Oct 21, 2026
This was referenced Oct 21, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Chidozie Ononiwu (chidozieononiwu)
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Oct 21, 2026
…40429) Sync .github/workflows directory with azure-sdk-tools for PR Azure/azure-sdk-tools#17346 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
Chidozie Ononiwu (chidozieononiwu)
added a commit
to Azure/azure-sdk-for-rust
that referenced
this pull request
Oct 21, 2026
…5501) Sync .github/workflows directory with azure-sdk-tools for PR Azure/azure-sdk-tools#17346 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> Co-authored-by: azure-sdk <azuresdk@microsoft.com>
Chidozie Ononiwu (chidozieononiwu)
merged commit Oct 21, 2026
ed62b5f
into
Azure:main
8 of 10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
event-processor.ymlGitHub Actions workflow to split event handling into two separate jobs, optimizing resource usage and permissions. Now, only newly opened issues trigger the Azure login and Key Vault secret retrieval, while all other events are handled in a streamlined job without unnecessary Azure steps.Workflow optimization and job separation:
event-handlerjob to handle all events except newly opened issues, reducing unnecessary Azure login overhead and limiting permissions to only what's needed.event-handler-with-azurejob so that Azure login and Key Vault access only occur for newly opened issues, improving efficiency and security.Permissions and configuration cleanup:
pull-requests: writeandcontents: read) from the Azure-related job, further tightening security.https://github.com/microsoft/mcp-pr/issues/733