Skip to content

Event processor - #17346

Merged
Chidozie Ononiwu (chidozieononiwu) merged 3 commits into
Azure:mainfrom
chidozieononiwu:EventProcessor
Oct 21, 2026
Merged

Chidozie Ononiwu (chidozieononiwu) merged 3 commits into
Azure:mainfrom
chidozieononiwu:EventProcessor

Conversation

@chidozieononiwu

@chidozieononiwu Chidozie Ononiwu (chidozieononiwu) commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

This pull request refactors the event-processor.yml GitHub Actions workflow to split event handling into two separate jobs, optimizing resource usage and permissions. Now, only newly opened issues trigger the Azure login and Key Vault secret retrieval, while all other events are handled in a streamlined job without unnecessary Azure steps.

Workflow optimization and job separation:

  • Added a new event-handler job to handle all events except newly opened issues, reducing unnecessary Azure login overhead and limiting permissions to only what's needed.
  • Updated the event-handler-with-azure job so that Azure login and Key Vault access only occur for newly opened issues, improving efficiency and security.

Permissions and configuration cleanup:

  • Removed unnecessary permissions (such as pull-requests: write and contents: read) from the Azure-related job, further tightening security.
  • Cleaned up commented-out sections related to building from source, focusing the workflow on installing the released tool version. [1] [2]

https://github.com/microsoft/mcp-pr/issues/733

Copilot AI balanced review requested due to automatic review settings October 21, 2026 04:02
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
71 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The complementary job conditions preserve event coverage, with appropriate permissions and no identified blocking issues.

No open issues 🎉

What changed in this PR

Splits event processing into separate jobs so only newly opened issues incur Azure authentication and Key Vault access.

Changes:

  • Adds a non-Azure job for all other events.
  • Narrows job permissions to their respective needs.
  • Removes commented-out build-from-source instructions.
File Description
.github/​workflows/​event-processor.yml Separates Azure-dependent processing from other events and reduces permissions.

Review effort: Balanced

Chidozie Ononiwu (chidozieononiwu) added a commit to Azure/azure-sdk-for-js that referenced this pull request Oct 21, 2026
…40429)

Sync .github/workflows directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#17346 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
Chidozie Ononiwu (chidozieononiwu) added a commit to Azure/azure-sdk-for-rust that referenced this pull request Oct 21, 2026
…5501)

Sync .github/workflows directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#17346 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
Co-authored-by: azure-sdk <azuresdk@microsoft.com>
@chidozieononiwu
Chidozie Ononiwu (chidozieononiwu) merged commit ed62b5f into Azure:main Oct 21, 2026
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants